feat: add EME2000 to frames ins satelles module - #249
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the EME2000 (J2000) reference frame as a first-class Frame in satelles.frames, with accompanying unit tests to validate its metadata and a known EME2000→ECI transform result.
Changes:
- Add
EME2000Framedefinition tosrc/satelles/frames.pywired to theeme2000_to_eci_transform_provider. - Extend
test/test_frames.pywith a newTestEME2000Frametest suite validating frame properties and a sample transform output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test_frames.py | Adds unit tests for the new EME2000 frame (properties + EME2000→ECI transform expectations). |
| src/satelles/frames.py | Defines and exports the EME2000 frame and hooks up its transform provider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michealroberts
force-pushed
the
feature/frames/EME2000
branch
from
April 15, 2026 15:32
f30b6c4 to
fa7a293
Compare
feat: add EME2000 to frames ins satelles module
michealroberts
force-pushed
the
feature/frames/EME2000
branch
from
April 15, 2026 15:35
fa7a293 to
dc8310f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add EME2000 to frames ins satelles module