fix(recipe): restore unconditional nlohmann_json; gate cpp_info entry… - #167
Merged
Conversation
… on with_onnx nlohmann_json is used unconditionally by src/ml/coco_dataset.cpp so it must always be in requirements(). However Conan 2's package_info() validation behaves differently across configurations: - static + with_onnx: onnxruntime also depends on nlohmann_json, making it visible in the graph; Conan requires it listed in cpp_info.requires. - static/shared + no_onnx: visible=False keeps it quiet; adding it to cpp_info.requires causes "not a direct requirement" on shared builds. Solution: keep nlohmann_json unconditional in requirements(), but only append "nlohmann_json::nlohmann_json" to cpp_info.requires inside the with_onnx guard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… on with_onnx
nlohmann_json is used unconditionally by src/ml/coco_dataset.cpp so it must always be in requirements(). However Conan 2's package_info() validation behaves differently across configurations:
Solution: keep nlohmann_json unconditional in requirements(), but only append "nlohmann_json::nlohmann_json" to cpp_info.requires inside the with_onnx guard.
Summary
Type of change
feat— new op / featurefix— bug fixdocs— tutorial, example, or doc commentbench— benchmarkchore— version bump, CI, build system, releaseOps / APIs added or changed
Test plan
cmake --build build --parallel— no errorscd build && ctest --output-on-failure— all tests pass (or pre-existing failures documented below)tests/Pre-existing test failures (if any)
None
CHANGELOG updated?
## [Unreleased](or version section for releases)