ci: add hassfest and HACS validation - #2
Merged
Conversation
Add hassfest and hacs jobs to ci.yml. Fix trivially-addressable gaps upfront: add integration_type to manifest.json and create strings.json matching translations/en.json. Hassfest runs continue-on-error until requirements are pinned in B5.
Remove invalid icon field from manifest.json (icons go in icons.json).
Fix services.yaml: response key must be {optional: bool}, and target
is required alongside response. Use hacs/action@main (v1.1.0 tag does
not exist).
Sort manifest.json keys in HA-required order (domain, name, then alphabetical). Remove response/target from services.yaml - response key format is not yet supported in current hassfest schema. Remove domains from hacs.json (deprecated key in newer HACS format).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hassfestandhacsjobs toci.ymlintegration_type: hubtomanifest.jsonand createsstrings.json(mirrorstranslations/en.json)hassfestruns ascontinue-on-error: trueuntil requirements inmanifest.jsonare pinned (B5 scope)hacsjob runs withoutcontinue-on-error— expected to pass cleanTest plan
hacsjob passes greenhassfestjob runs (may fail on unpinned requirements — expected,continue-on-error)lintandtestjobs still pass