fix(engine): report diagnostic for empty source instead of IndexError#54
Merged
michaelkamprath merged 2 commits intoMay 20, 2026
Merged
Conversation
michaelkamprath
left a comment
Owner
There was a problem hiding this comment.
Thanks for the fix! The core change is correct — diagnostic_reporter.error() calls sys.exit(), so the IndexError crash on the next line is properly prevented. A few minor suggestions below.
Contributor
Author
|
Moved the guard before the sort and switched to |
michaelkamprath
approved these changes
May 20, 2026
michaelkamprath
left a comment
Owner
There was a problem hiding this comment.
Thanks for the contribution!
closes #53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling an empty source file crashed with
IndexError: list index out of rangeatengine.pybecausecompilable_line_obs[-1]was accessed on an empty list. The engine now reports a clearsource file contains no compilable linesdiagnostic in that case. Closes #53.