fan: handle bridge errors as HomeAssistantError#137
Merged
michaelarnauts merged 1 commit intoApr 22, 2026
Merged
Conversation
Wrap set_speed() and set_mode() bridge calls with exception handlers for ComfoConnectNotConnected and ComfoConnectRmiError, re-raising both as HomeAssistantError. This surfaces bridge rejections (e.g. RMI_ERROR) as a user-facing HA notification instead of an unhandled exception in the logs.
Contributor
Author
|
The fix wraps async_set_percentage and async_set_preset_mode with exception handling. async_turn_on and async_turn_off are covered transitively since they delegate to those two methods. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap set_speed() and set_mode() bridge calls with exception handlers for ComfoConnectNotConnected and ComfoConnectRmiError, re-raising both as HomeAssistantError. This surfaces bridge rejections (e.g. RMI_ERROR) as a user-facing HA notification instead of an unhandled exception in the logs.
This is improving the experience reports in #126 but not solving the underlying issue.