Conversation
Release v0.15.0-beta.1: develop → main
- Add token.helper.spec.ts: getTokenErrorInfo, isTokenError, isSessionExpiredError, logTokenError - Add content-encoding.helper.spec.ts: decodeContent, encodeContent, round-trip - Fix content-encoding: swap deflate encode/decode (inflateSync/deflateSync) - Fix token.helper: match 'session has expired', return false when data missing
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PP-2963: Fix package vulnerabilities and add logic tests
Summary
This PR addresses package vulnerabilities across the project and test apps, plus adds unit tests for token and content-encoding helper logic.
Changes
1. Package Vulnerability Fixes
Root package:
file-typefrom ^19.6.0 → ^21.3.1 (fixes GHSA-5v7r-6r5c-r473)svgo,rollup,immutable,minimatch,tarvianpm audit fixTest projects (
test-commonjs,test-nextjs,test-nextjs-cjs):file-typeandminimatchfile-type,svgo,rollupin test-nextjs)npm audit fixResult: All projects report 0 vulnerabilities.
2. Logic Tests
tests/unit/lib/token.helper.spec.ts(25 tests):getTokenErrorInfo— 401, 403, 412 (session expired vs auth failed), unknown status, message fallbacksisTokenErrorandisSessionExpiredError— status and message variantslogTokenError— logger calls, context prefix, suggestionstests/unit/lib/content-encoding.helper.spec.ts(17 tests):decodeContent/encodeContent— gzip, brotli, deflate, default/unknown encoding3. Implementation Fixes (discovered via tests)
content-encoding.helper.ts: Fixed swapped deflate logic — decode now uses
inflateSync(decompress), encode usesdeflateSync(compress)token.helper.ts: Extended session-expired check to handle both
"session expired"and"session has expired";isSessionExpiredErrorreturnsfalsewhenresponse.datais missing (was returningundefined)Testing
npm run test:unit— 137 tests passingnpm run test:integration— 31 tests passingnpm audit— 0 vulnerabilitiesChecklist