fix(PP-3449): guard release.yml against non-tag workflow_dispatch runs - #187
Merged
Conversation
workflow_dispatch lets this workflow run against any ref (branch or tag). Without a check, dispatching against main/develop would derive VERSION from the branch name and proceed to build/bump/publish with a bogus version. Exit early unless GITHUB_REF_NAME matches a v* tag. Addresses CodeRabbit review comment on PR #186.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses a CodeRabbit review comment on #186:
workflow_dispatch(added in #184) letsrelease.ymlrun against any ref, not just a version tag. Without a guard, dispatching the workflow againstmain/developwould deriveVERSIONfrom the branch name (VERSION=${GITHUB_REF_NAME#v}) and proceed straight to build,npm version, andnpm publishwith a bogus version string.Fix
Exit early with a clear error unless
GITHUB_REF_NAMEmatches av*tag:Manual re-runs via
gh workflow run release.yml --ref v1.0.0-beta.1are unaffected; only non-tag refs are rejected.Testing
Merge Request:
origin/pp-3449-release-tag-guard→origin/develop