Promotes the current **develop** line to **main**, including security-focused dependency work, test-sandbox alignment, packaged postinstall fix, Next.js dev Webpack fallback, and release **0.17.0-beta.1** (via chore(release) on develop).
#117
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,30 @@ | ||||||||||||||||||||||||||||||||||||||||||||||
| /** | ||||||||||||||||||||||||||||||||||||||||||||||
| * The `npm` package vendors dependencies (bundleDependencies). npm overrides do not | ||||||||||||||||||||||||||||||||||||||||||||||
| * replace those copies, so `npm audit` still flags known-fixed versions that exist | ||||||||||||||||||||||||||||||||||||||||||||||
| * hoisted at the project root. Sync patched trees into npm's bundle after install. | ||||||||||||||||||||||||||||||||||||||||||||||
| */ | ||||||||||||||||||||||||||||||||||||||||||||||
| import { cpSync, existsSync, rmSync } from "node:fs"; | ||||||||||||||||||||||||||||||||||||||||||||||
| import { dirname, join } from "node:path"; | ||||||||||||||||||||||||||||||||||||||||||||||
| import { fileURLToPath } from "node:url"; | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| const root = join(dirname(fileURLToPath(import.meta.url)), ".."); | ||||||||||||||||||||||||||||||||||||||||||||||
| const npmRoot = join(root, "node_modules", "npm"); | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| function replaceDir(src, dest) { | ||||||||||||||||||||||||||||||||||||||||||||||
| if (!existsSync(src) || !existsSync(dirname(dest))) { | ||||||||||||||||||||||||||||||||||||||||||||||
| return; | ||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
| rmSync(dest, { recursive: true, force: true }); | ||||||||||||||||||||||||||||||||||||||||||||||
| cpSync(src, dest, { recursive: true }); | ||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+13
to
+19
There was a problem hiding this comment. Don't let a best-effort postinstall patch fail the install. This helper is called from the published 🔧 Safer postinstall patching function replaceDir(src, dest) {
if (!existsSync(src) || !existsSync(dirname(dest))) {
return;
}
- rmSync(dest, { recursive: true, force: true });
- cpSync(src, dest, { recursive: true });
+ try {
+ rmSync(dest, { recursive: true, force: true });
+ cpSync(src, dest, { recursive: true });
+ } catch (error) {
+ console.warn(
+ `[pp-dev] Skipping bundled npm patch for ${dest}: ${
+ error instanceof Error ? error.message : String(error)
+ }`,
+ );
+ }
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| if (existsSync(npmRoot)) { | ||||||||||||||||||||||||||||||||||||||||||||||
| replaceDir( | ||||||||||||||||||||||||||||||||||||||||||||||
| join(root, "node_modules", "brace-expansion"), | ||||||||||||||||||||||||||||||||||||||||||||||
| join(npmRoot, "node_modules", "brace-expansion"), | ||||||||||||||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||||||||||||||
| replaceDir( | ||||||||||||||||||||||||||||||||||||||||||||||
| join(root, "node_modules", "picomatch"), | ||||||||||||||||||||||||||||||||||||||||||||||
| join(npmRoot, "node_modules", "tinyglobby", "node_modules", "picomatch"), | ||||||||||||||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the heading jump and expand the release notes.
The new entry goes from
#to###, which is why markdownlint reports MD001 here. I'd also call out the dependency/toolchain compatibility changes and the packaged security patch in this release so the changelog matches what0.17.0-beta.1actually ships.As per coding guidelines, "Use proper markdown headers (##, ###) for GitHub compatibility in PR messages", "List specific technical improvements in PR messages", and "Specify breaking changes or compatibility in PR messages".
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 4-4: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3
(MD001, heading-increment)
🤖 Prompt for AI Agents