Skip to content

fix: only prepend zeros in polyphase non-streaming when mode="full" #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robrui wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: only prepend zeros in polyphase non-streaming when mode="full" #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sdr/_filter/_polyphase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,11 @@ def _polyphase_input_commutate(

self._state = x_pad[-(B * M - 1) :]
else:
# Prepend zeros to so the first sample is alone in the first commutated column
x_pad = np.insert(x, 0, np.zeros(B - 1))
# Only prepend zeros in "full" mode; in "rate" mode they misalign decimation
if mode == "full":
x_pad = np.insert(x, 0, np.zeros(B - 1))
else:
x_pad = x
# Append zeros to input signal to distribute evenly across the B branches
x_pad = np.append(x_pad, np.zeros(B - (x_pad.size % B), dtype=dtype))
X_cols = x_pad.size // B
Expand Down
Loading