add multi-gauge facilitation - #10
Open
lotruheawea wants to merge 7 commits into
Open
Conversation
- implemented first version of batchprocessing of idgauges.asc file (still buggy, facc values are written although full_like is used)
…pandas dependency, fixed bug when writing basin mask, refactored types of gauge attributes
MuellerSeb
reviewed
Nov 11, 2022
MuellerSeb
left a comment
MuellerSeb
left a comment
Member
There was a problem hiding this comment.
Minor comments. Let's see what CI says.
| sudo apt-get update | ||
| sudo apt install gdal-bin libgdal-dev | ||
| pip install wheel numpy | ||
| pip install wheel numpy pandas |
Member
There was a problem hiding this comment.
you don't need to add pandas here (it's only to install gdal correctly)
| ``` | ||
| brew install gdal | ||
| pip install wheel numpy | ||
| pip install wheel numpy pandas |
Member
There was a problem hiding this comment.
you don't need to add pandas here (it's only to install gdal correctly)
| To use the development version of basinex, download this repository and do the following in your conda environment: | ||
|
|
||
| conda install -y gdal netcdf4 pyyaml cxx-compiler | ||
| conda install -y gdal netcdf4 pyyaml cxx-compiler pandas |
| The gauge matching is based on the flowaccumulation data. The value for | ||
| any given cell in the flowaccumulation grid is interpreted as the size | ||
| [in cells] of a river basin drainig into the respective cell. | ||
| [in cells] of a river basin draining into the respective cell. |
| import numpy as np | ||
|
|
||
| # precision for rounding to avoid numerical instabilities | ||
| PRECISION = 10 |
Member
There was a problem hiding this comment.
Maybe make this an optional input in the config.yaml file?
| fill_value=var.fill_value, | ||
| cellsize=nc.cellsize, | ||
| ) | ||
| out._fobj = None |
Member
There was a problem hiding this comment.
This is so strange, but thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implemented some new features