Skip to content

Fix D3 type errors #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhkeller merged 4 commits into from
Jul 17, 2026
Merged

Fix D3 type errors #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
444a584
Import d3 library types explicitly
rgieseke Jul 17, 2026
2a81122
Fix d3 type errors
rgieseke Jul 17, 2026
3cbcadb
Add lock file
rgieseke Jul 17, 2026
ad14548
Update test output after type updates
rgieseke Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@
"@sveltejs/package": "^2.5.7",
"@sveltejs/vite-plugin-svelte": "^7.2.0",
"@types/d3": "^7.4.3",
"@types/d3-hierarchy": "^3.1.7",
"@types/d3-sankey": "^0.12.4",
"@types/d3-scale": "^4.0.9",
"@types/d3-shape": "^3.1.8",
"@types/markdown-it": "^14.1.2",
"@types/node": "^26.1.1",
"d3-collection": "^1.0.7",
Expand Down
9 changes: 9 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/_components/CirclePack.html.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

const { width, height, data } = getContext('LayerCake');

/** @typedef {import('d3-hierarchy').HierarchyNode} HierarchyNode */
/** @typedef {import('d3-hierarchy').HierarchyNode<any>} HierarchyNode */

/**
* @typedef {Object} Props
Expand Down
8 changes: 4 additions & 4 deletions src/_components/Sankey.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
* )} SankeyAlignment
*/

/** @typedef {import('d3-sankey').SankeyGraph} SankeyGraph */
/** @typedef {import('d3-sankey').SankeyGraph<any, any>} SankeyGraph */

/** @typedef {import('d3-sankey').SankeyNodeMinimal} SankeyNodeMinimal */
/** @typedef {import('d3-sankey').SankeyNodeMinimal<any, any>} SankeyNodeMinimal */

/** @typedef {import('d3-sankey').SankeyLinkMinimal} SankeyLink */
/** @typedef {import('d3-sankey').SankeyLinkMinimal<any, any>} SankeyLink */

/**
* @typedef {((a: SankeyLink, b: SankeyLink) => (number | undefined | null))} LinkSortFunction
Expand All @@ -35,7 +35,7 @@
* @property {number} [nodeWidth=5] - The width of each node, in pixels, passed to [`sankey.nodeWidth`](https://github.com/d3/d3-sankey#sankey_nodeWidth).
* @property {number} [nodePadding=10] - The padding between nodes, passed to [`sankey.nodePadding`](https://github.com/d3/d3-sankey#sankey_nodePadding).
* @property {LinkSortFunction|undefined} [linkSort] - How to sort the links, passed to [`sankey.linkSort`](https://github.com/d3/d3-sankey#sankey_linkSort).
* @property {(SankeyNodeMinimal) => number | string} [nodeId=(d) => d.id] - The ID field accessor, passed to [`sankey.nodeId`](https://github.com/d3/d3-sankey#sankey_nodeId).
* @property {(d: SankeyNodeMinimal) => number | string} [nodeId=(d) => d.id] - The ID field accessor, passed to [`sankey.nodeId`](https://github.com/d3/d3-sankey#sankey_nodeId).
* @property {SankeyAlignment} [nodeAlign=Sankey.sankeyLeft] - An alignment function to position the Sankey blocks. See the [d3-sankey documentation](https://github.com/d3/d3-sankey#alignments) for more.
*/

Expand Down
6 changes: 3 additions & 3 deletions ...es-table.spec.js-snapshots/Property-table-content-for-components-Sankey-svelte-1.aria.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@
- /url: https://github.com/d3/d3-sankey#sankey_linkSort
- code: sankey.linkSort
- text: ""
- row "nodeId ((SankeyNodeMinimal) => number | string) d => d.id no The ID field accessor, passed to sankey.nodeId.":
- cell "nodeId ((SankeyNodeMinimal) => number | string)":
- 'row "nodeId ((d: SankeyNodeMinimal) => number | string) d => d.id no The ID field accessor, passed to sankey.nodeId."':
- 'cell "nodeId ((d: SankeyNodeMinimal) => number | string)"':
- strong: nodeId
- text: ""
- code: (SankeyNodeMinimal) => number
- code: "(d: SankeyNodeMinimal) => number"
- text: ""
- code: string
- text: ""
Expand Down
Loading