perf: use HashSet<string> for NoWarn code lookups#76
Closed
mfogliatto-dev-agent wants to merge 1 commit into
Closed
perf: use HashSet<string> for NoWarn code lookups#76mfogliatto-dev-agent wants to merge 1 commit into
mfogliatto-dev-agent wants to merge 1 commit into
Conversation
Replace IEnumerable<string> with HashSet<string> for NoWarn codes at the provider level, converting O(n) LINQ Contains lookups to O(1) HashSet lookups in ReferenceEvaluationContextFactory.Create. Changed types in: - INoWarnAssembliesProvider: Dictionary value type -> HashSet<string> - NoWarnAssembliesProvider: Produces HashSet<string> instead of arrays - ProjectReferenceInfo: NoWarn property -> HashSet<string> - MSBuildProjectMetadataProvider: Wraps split results in HashSet<string> Fixes #71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
IEnumerable<string>withHashSet<string>for NoWarn codes at the provider level, converting O(n) linear LINQContainslookups to O(1)HashSetlookups inReferenceEvaluationContextFactory.Create.Changes
INoWarnAssembliesProvider.csIEnumerable<string>→HashSet<string>NoWarnAssembliesProvider.csHashSet<string>instead ofstring[]ProjectReferenceInfo.csNoWarnproperty typeIEnumerable<string>→HashSet<string>MSBuildProjectMetadataProvider.csHashSet<string>How it works
The optimization is applied at the provider level — where NoWarn codes are first materialized from config strings. This means:
NoWarnAssembliesProvider.GetNoWarnByAssembly()now returnsDictionary<string, HashSet<string>>. TheHashSetvalues flow throughReferenceCopAnalyzer.AnalyzeCompilationintoReferenceEvaluationContextFactory.Create, where LINQ'sEnumerable.Contains()detects the underlyingICollection<T>and dispatches toHashSet<T>.Contains()— O(1).MSBuildProjectMetadataProviderproducesProjectReferenceInfowithHashSet<string>NoWarn codes, achieving the same O(1) lookup.The factory's parameter type (
IEnumerable<string>) is intentionally unchanged to minimize API surface impact — the performance gain comes from the concreteHashSetpassed in at runtime.Testing
NoWarnAssembliesProviderTestsvalidates the provider behavior with the newHashSetreturn typeFixes #71