Symfony 8 support and improvements - #6
Merged
Merged
Conversation
**File:** `src/Gateway/Builder/AbstractGatewayDefinitionBuilder.php`
`configureOptions()` registers a `gateway_endpoints` sub-resolver requiring `payment_api` and defining `gateway_3d_host`. When a builder then calls `$this->require3DGateway($resolver)`, it calls `setDefault('gateway_endpoints', ...)` again, replacing the previous closure — dropping the `payment_api` requirement and `gateway_3d_host` definition entirely.
Fix: make `require3DGateway` extend the existing sub-resolver rather than replacing it, or fold the 3D gateway requirement into the parent with a boolean flag.
soap extension is needed since mews/pos v1.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eklendi
symfony/config,symfony/dependency-injection,symfony/http-kernelvb. bağımlılıklar^8.0sürümüyle genişletildi)AccountFactoryTest,AbstractGatewayDefinitionBuilderTest,EstV3PosDefinitionBuilderTest,GatewayFactoryTest,GatewayDefinitionFactoryTestDüzeltildi
AbstractGatewayDefinitionBuilder'darequire3DGateway()çağrısı, üst sınıfıngateway_endpointsalt çözücüsünü sessizce üzerine yazarakpayment_apizorunluluğunu vegateway_3d_hosttanımını siliyordu. Mevcut alt çözücünün genişletilmesiyle bu hata giderildi.Yeniden Düzenlendi
GatewayDefinitionFactory: Yapılandırmada desteklenmeyen birgateway_classtanımlandığında artık açıklayıcı birInvalidArgumentExceptionfırlatılıyorAbstractGatewayDefinitionBuilder: PHP eklentisi kontrolü basitleştirildiext-soapeklendi zorunluluğu kaldırıldıAccountFactory: Hata mesajı daha açıklayıcı hale getirildi