fix: preserve query params on by_url_identifier redirect - #67
Merged
Conversation
thiagogds
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/metr-systems/backlog/issues/4861
AI Disclaimer: Yes — used Claude Code
Summary
Dashboard links built from the overview in SE dashboards (e.g.
/dashboards/by_url_identifier/anlagendetails?p_Liegenschaft=<uuid>) were losing their query parameters during the redirect to the canonical org dashboard URL.The building UUID got dropped, so the dashboard couldn't open for the correct building.
This fix restores the parameters so overview → details navigation works as intended for the SE team's templates.
Code Strategy
The fix re-appends
request.query_stringonly when present, which preserves every parameter, their order, and existing URL-encoding without parsing/reconstructing. No-param redirects don't regress.QA
How did you test it? Keep your future self in mind to help debug things later.