Update parallel benchmarks (Promise + Compose) - #395
Open
lundibundi wants to merge 2 commits into
Open
Conversation
belochub
approved these changes
Dec 6, 2018
Member
|
We need to use const f = callback => queueMicrotask(() => callback(10));
f(res => {
console.log(res);
});
const p = new Promise(resolve => resolve(10));
console.dir({ p });Output will be: If we add const f = callback => queueMicrotask(() => callback(10));
f(res => {
console.log(res);
});
const p = new Promise(resolve => queueMicrotask(() => resolve(10)));
p.then(res => {
console.dir({ res });
});Output will be: Now two cases are equal priority, so if we swap calls results will swap too: const f = callback => queueMicrotask(() => callback(10));
const p = new Promise(resolve => queueMicrotask(() => resolve(10)));
p.then(res => {
console.dir({ res });
});
f(res => {
console.log(res);
});Output will be: |
* Don't create object every time in Promise resolve * Collect results in an array in Compose bench as it is dome in Promise.all
lundibundi
force-pushed
the
fix-promise-all-benchs
branch
from
April 17, 2019 07:07
0a13d38 to
a128d74
Compare
nechaido
approved these changes
Apr 17, 2019
SemenchenkoVitaliy
approved these changes
Apr 18, 2019
belochub
approved these changes
Apr 26, 2019
Member
Author
|
ping @tshemsedinov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in Promise.all