Skip to content

fix: manually fix createidempotentAssociatedToken data serialization - #17

Open
swimricky wants to merge 1 commit into
metaplex-foundation:mainfrom
swimricky:fix/create-ata-idempotent
Open

fix: manually fix createidempotentAssociatedToken data serialization#17
swimricky wants to merge 1 commit into
metaplex-foundation:mainfrom
swimricky:fix/create-ata-idempotent

Conversation

@swimricky

@swimricky swimricky commented Apr 23, 2026

Copy link
Copy Markdown

Manually fixes the data serialization for createAssociatedTokenIdempotent

prior to this fix, the instruction is processed as the plain createAssociatedTokenAccount since the data is empty (https://github.com/solana-program/associated-token-account/blob/0b867b5340cd001e5980d8ca7928effc4e10015c/program/src/processor.rs#L42) and if you pass in an ATA account that's already initialized(or any account not owned by the system program), the transaction will fail.
https://github.com/solana-program/associated-token-account/blob/program%40v8.0.0/program/src/processor.rs#L107-L109

I ran the pnpm generate:client and it didn't update anything. Didn't have time to look into kinobi (dont know if it's even still actively maintained) to see where the root cause was from that side.

@vercel

vercel Bot commented Apr 23, 2026

Copy link
Copy Markdown

@swimricky is attempting to deploy a commit to the Metaplex Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • clients/js/src/generated/instructions/createIdempotentAssociatedToken.ts is excluded by !**/generated/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46d3f1fd-5054-4aa8-9fc8-0366560c5f50

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant