Moving ME checks to the plugin.

[blockiosaurus]

Summary by CodeRabbit

• Bug Fixes

  • Implemented stricter validation to prevent MasterEdition plugins from being added to assets in restricted contexts.

• Error Handling

  • Improved error reporting with more specific and descriptive messages for invalid plugin operations.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
mpl-core-js-docs	Ready	Preview, Comment	Apr 19, 2026 1:33pm

[coderabbitai]

Caution

Review failed

Failed to post review comments

Walkthrough

A new error variant PluginNotAllowedOnAsset is introduced across the IDL and error definitions, and MasterEdition plugin validation is refactored from blanket processor-level rejection to conditional validation logic within the plugin itself. Processors and lifecycle mappings are updated to accommodate this change.

Changes

Cohort / File(s)	Summary
Configuration .coderabbit.yaml	Added CodeRabbit configuration file with review automation settings, including profile, summaries, poem generation, and path-based review instructions.
Error Definitions idls/mpl_core.json, programs/mpl-core/src/error.rs	Introduced new PluginNotAllowedOnAsset error variant (code 57) across both IDL and Rust error module with message "Plugin is not allowed to be added to an Asset".
Plugin Validation programs/mpl-core/src/plugins/internal/authority_managed/master_edition.rs	Expanded MasterEdition PluginValidation implementation with explicit validate_create and validate_add_plugin methods that conditionally reject when MasterEdition targets an asset.
Lifecycle Permissions programs/mpl-core/src/plugins/lifecycle.rs	Added PluginType::MasterEdition handling to return CheckResult::CanReject in both check_add_plugin and check_create match arms.
Processors programs/mpl-core/src/processor/add_plugin.rs, programs/mpl-core/src/processor/create.rs	Removed blanket MasterEdition rejection from add_plugin; updated create to pass target_plugin context to validation and remove MasterEdition from early-return filter.
Tests clients/js/test/plugins/collection/masterEdition.test.ts	Updated test expectations to assert PluginNotAllowedOnAsset error instead of InvalidPlugin for two error cases.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A fluffy validation dance,
MasterEdition takes its stance,
From blanket no to context-wise,
The plugin learns to scrutinize,
With error codes and checks so keen,
The cleanest code we've ever seen! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Moving ME checks to the plugin' accurately reflects the main change: refactoring MasterEdition validation from processor-level checks to plugin-level validation logic.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/resolve-pr-222-conflicts-ijaDA

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Benchmark

Details

Benchmark suite	Current: 4fa97e2	Previous: 6f2f577	Ratio
CU: create a new, empty asset	8023 Compute Units	8022 Compute Units	1.00
Space: create a new, empty asset	91 Bytes	91 Bytes	1
CU: create a new, empty asset with empty collection	16840 Compute Units	16839 Compute Units	1.00
Space: create a new, empty asset with empty collection	91 Bytes	91 Bytes	1
CU: create a new asset with plugins	26610 Compute Units	26608 Compute Units	1.00
Space: create a new asset with plugins	194 Bytes	194 Bytes	1
CU: create a new asset with plugins and empty collection	31938 Compute Units	31936 Compute Units	1.00
Space: create a new asset with plugins and empty collection	194 Bytes	194 Bytes	1
CU: list an asset	20041 Compute Units	20043 Compute Units	1.00
CU: sell an asset	25233 Compute Units	25233 Compute Units	1
CU: list an asset with empty collection	24991 Compute Units	24993 Compute Units	1.00
CU: sell an asset with empty collection	33304 Compute Units	33304 Compute Units	1
CU: list an asset with collection royalties	24274 Compute Units	24276 Compute Units	1.00
CU: sell an asset with collection royalties	36089 Compute Units	36089 Compute Units	1
CU: transfer an empty asset	3785 Compute Units	3785 Compute Units	1
CU: transfer an empty asset with empty collection	5498 Compute Units	5498 Compute Units	1
CU: transfer an asset with plugins	7213 Compute Units	7213 Compute Units	1
CU: transfer an asset with plugins and empty collection	8926 Compute Units	8926 Compute Units	1

This comment was automatically generated by workflow using github-action-benchmark.