Feat/nori docs - #545
Open
tonyboylehub wants to merge 3 commits into
Open
Conversation
Four new pages under /agents/nori covering the Nori service agent for the agent-builder persona: - Overview: services, payment rails, single-point-of-failure caveat (self-hosting deferred to v2), reference-implementation patterns - Delegate to Nori: free onboarding flow, bearer-token auth, funding, revocation, common errors - Pricing and Billing: rate card, charge-on-success accounting, price-change notice policy, hard stops on undelegate and wallet-empty - Example Agents: consumers for chat.completion, image.generation, solana.rpc (incl. DAS), and raw A2A message/send Wires Nori into the agents product nav, the top-level nav menu, and llms.txt.
Locale parity for the four /agents/nori pages. Prose, headings, and title/metaTitle/description/faqs/howToSteps frontmatter translated; keywords, about, dates, and code blocks kept in English per the localisation rules. In-page and cross-page anchors remapped to the translated headings, terminology aligned with the existing locale agents pages.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Summary by CodeRabbit
WalkthroughAdds Nori to Agents navigation and ChangesNori documentation rollout
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/en/agents/nori/delegate-to-nori.md`:
- Around line 85-93: Protect the fetch-nori-card.ts example from an untrusted
NORI_URL by validating the origin against the pinned trusted value, verifying
the signed agent card, or deriving and comparing the expected
serviceExecutiveAddress before using it for delegation. Apply the same
validation behavior in the English source at
src/pages/en/agents/nori/delegate-to-nori.md lines 85-93 and mirror the
corresponding change in src/pages/ja/agents/nori/delegate-to-nori.md lines
85-93, src/pages/ko/agents/nori/delegate-to-nori.md lines 85-93, and
src/pages/zh/agents/nori/delegate-to-nori.md lines 85-93.
In `@src/pages/en/agents/nori/example-agents.md`:
- Around line 204-205: Align the x402 FAQ wording with the billing behavior by
stating that the upstream call runs once before payment and its result is
cached, or narrow the explanation to delegated calls. Apply the corresponding
correction in src/pages/en/agents/nori/example-agents.md lines 204-205,
src/pages/ja/agents/nori/example-agents.md lines 204-205, and
src/pages/ko/agents/nori/example-agents.md lines 204-205, preserving each
language’s existing style.
- Around line 83-98: Update the no-delegation examples so payment and error
responses are handled before successful-result access: in
src/pages/en/agents/nori/example-agents.md ranges 83-98, 107-117, and 139-167,
check HTTP 402 before reading response.data[0], expose and handle x402
challenges instead of returning undefined, and handle A2A error/payment
responses before treating the task as complete; apply the corresponding HTTP,
RPC, and A2A handling in the same ranges of
src/pages/ja/agents/nori/example-agents.md and
src/pages/ko/agents/nori/example-agents.md.
In `@src/pages/en/agents/nori/index.md`:
- Around line 108-110: Add concise BLUF content to every listed Quick Reference
and FAQ section: insert a declarative sentence immediately before each Quick
Reference table, and replace each generic FAQ introduction with a direct answer.
Apply the corresponding localized wording in src/pages/en/agents/nori/index.md
(108-110, 131-133), src/pages/ja/agents/nori/index.md (108-110, 131-133),
src/pages/en/agents/nori/example-agents.md (176-180, 194-196),
src/pages/ja/agents/nori/example-agents.md (176-180, 194-196),
src/pages/ko/agents/nori/example-agents.md (176-180, 194-196),
src/pages/en/agents/nori/pricing-and-billing.md (143-147, 167-169),
src/pages/ja/agents/nori/pricing-and-billing.md (143-147, 167-169), and
src/pages/ko/agents/nori/pricing-and-billing.md (143-147, 167-169).
- Around line 37-41: Move each page’s lead paragraph so it appears immediately
below its Summary heading: src/pages/en/agents/nori/index.md (37-41),
src/pages/ja/agents/nori/index.md (37-41),
src/pages/en/agents/nori/example-agents.md (37-41),
src/pages/ja/agents/nori/example-agents.md (37-41),
src/pages/ko/agents/nori/example-agents.md (37-41),
src/pages/en/agents/nori/pricing-and-billing.md (38-42),
src/pages/ja/agents/nori/pricing-and-billing.md (38-42), and
src/pages/ko/agents/nori/pricing-and-billing.md (38-42); preserve each page’s
existing localized heading and lead text.
In `@src/pages/zh/agents/nori/example-agents.md`:
- Around line 83-97: Update the image-generation example around the fetch
response and imageB64 extraction to check response.ok and validate that
response.data contains an image before dereferencing it; handle failures
explicitly. Apply the same validation to noriRpc: check HTTP success,
parse/validate the JSON-RPC response, and ensure result exists before returning
it so later agent logic never receives undefined data.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ad8f9e92-c33c-4264-83f7-8e81e5e7703c
📒 Files selected for processing (19)
public/llms.txtsrc/components/NavList.jsxsrc/components/products/agents/index.jssrc/pages/en/agents/nori/delegate-to-nori.mdsrc/pages/en/agents/nori/example-agents.mdsrc/pages/en/agents/nori/index.mdsrc/pages/en/agents/nori/pricing-and-billing.mdsrc/pages/ja/agents/nori/delegate-to-nori.mdsrc/pages/ja/agents/nori/example-agents.mdsrc/pages/ja/agents/nori/index.mdsrc/pages/ja/agents/nori/pricing-and-billing.mdsrc/pages/ko/agents/nori/delegate-to-nori.mdsrc/pages/ko/agents/nori/example-agents.mdsrc/pages/ko/agents/nori/index.mdsrc/pages/ko/agents/nori/pricing-and-billing.mdsrc/pages/zh/agents/nori/delegate-to-nori.mdsrc/pages/zh/agents/nori/example-agents.mdsrc/pages/zh/agents/nori/index.mdsrc/pages/zh/agents/nori/pricing-and-billing.md
…rust - Correct the example-agents FAQ (body + faqs frontmatter, all locales): a non-delegated first call runs the request once and returns HTTP 402; paying and retrying returns the cached result. Previous wording said the call was not executed, contradicting the charge-on-success documentation on the pricing page. - Add a warning callout to the delegation guide (all locales): the agent card fetched from NORI_URL determines the executive profile granted billing authority, so treat the base URL as trusted configuration and verify serviceExecutiveAddress out-of-band before signing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.