Fix typos and a broken link in English docs - #543
Conversation
Correct grammar and spelling issues across Core, Candy Machine, Bubblegum, and Umi pages, and point the empty collection FAQ link to the in-page section.
|
@Mibrahimwali is attempting to deploy a commit to the Metaplex Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Summary by CodeRabbit
WalkthroughThis PR corrects wording across developer documentation. It also updates the Core transfer guide with a valid FAQ anchor and corrected public-key variables in its JavaScript example. ChangesDocumentation corrections
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/pages/en/smart-contracts/bubblegum/guides/javascript/how-to-create-1000000-nfts-on-solana.md`:
- Line 95: Update the introductory sentence to declaratively state that the
example sets up Umi with generateSigner(umi), replacing the incorrect
generatedSigner() reference while preserving the surrounding React and
wallet-setup guidance.
In
`@src/pages/en/smart-contracts/candy-machine/custom-guards/generating-client.md`:
- Line 66: Rewrite the sentence to use a direct declarative construction and
correct punctuation, stating that the generated client is located in
`/clients/js/src` and directing the reader to navigate there after generation.
In `@src/pages/en/smart-contracts/core-candy-machine/create.md`:
- Line 288: Clarify the storage-savings sentence by stating that the Core Candy
Machine stores the name prefix once and appends each mint’s index at mint time,
reducing account storage and the associated rent cost; avoid describing bytes
themselves as rent.
In `@src/pages/en/smart-contracts/core/transfer.md`:
- Line 101: Update the transfer example containing collection.publicKey to
define collection and newOwner within the same snippet, or include explicit
setup for both before they are used. Keep the existing asset transfer flow
intact and ensure the copied example runs without ReferenceError.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 17744acc-7d7b-49d5-9273-2fcc65fb0ff5
📒 Files selected for processing (9)
src/pages/en/dev-tools/umi/getting-started/index.mdsrc/pages/en/dev-tools/umi/toolbox/token-managment.mdsrc/pages/en/smart-contracts/bubblegum/guides/javascript/how-to-create-1000000-nfts-on-solana.mdsrc/pages/en/smart-contracts/candy-machine/custom-guards/generating-client.mdsrc/pages/en/smart-contracts/candy-machine/insert-items.mdsrc/pages/en/smart-contracts/core-candy-machine/create.mdsrc/pages/en/smart-contracts/core-candy-machine/insert-items.mdsrc/pages/en/smart-contracts/core/external-plugins/overview.mdsrc/pages/en/smart-contracts/core/transfer.md
Use generateSigner(umi), clarify guard client and prefix storage wording, and make the Core collection transfer example self-contained.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/pages/en/smart-contracts/bubblegum/guides/javascript/how-to-create-1000000-nfts-on-solana.md`:
- Line 95: Update the explanatory text around the `generateSigner(umi)` example
to use “set up” as the verb, add the required articles, and insert the comma
that clarifies the wallet guidance while preserving the intended React and
wallet-adapter instructions.
In `@src/pages/en/smart-contracts/core/transfer.md`:
- Around line 99-100: Replace the placeholder values used by collection and
newOwner with valid Solana public-key strings that decode to 32 bytes, using
real recipient addresses or known valid base58 examples. Keep the publicKey
calls and transferV1 flow unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 68d7b89c-3093-4d81-811b-ab503195e0d2
📒 Files selected for processing (4)
src/pages/en/smart-contracts/bubblegum/guides/javascript/how-to-create-1000000-nfts-on-solana.mdsrc/pages/en/smart-contracts/candy-machine/custom-guards/generating-client.mdsrc/pages/en/smart-contracts/core-candy-machine/create.mdsrc/pages/en/smart-contracts/core/transfer.md
Fix remaining set up wording on the Bubblegum guide and replace invalid collection/owner placeholder keys in the Core transfer examples.
|
Hi, @MarkSackerberg, I am trying to contribute starting from a small update PR. Can you please review for me. Thank you |
1 participant
Correct grammar and spelling issues across Core, Candy Machine, Bubblegum, and Umi pages, and point the empty collection FAQ link to the in-page section.