Skip to content

mpl-core-das improve package visibility - #541

Open
MarkSackerberg wants to merge 1 commit into
mainfrom
fix/mpl-core-das-improvements
Open

mpl-core-das improve package visibility#541
MarkSackerberg wants to merge 1 commit into
mainfrom
fix/mpl-core-das-improvements

Conversation

@MarkSackerberg

Copy link
Copy Markdown
Contributor

The package name was not part of the overview page, so if you did not follow the initial getting-started page you would be lost

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
developer-hub Ready Ready Preview, Comment Jul 22, 2026 4:58pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d70b1752-6999-49e1-b929-746954a8c376

📥 Commits

Reviewing files that changed from the base of the PR and between e1cf9db and d3cc593.

📒 Files selected for processing (9)
  • src/components/products/das-api/index.js
  • src/pages/en/dev-tools/das-api/core-extension/index.md
  • src/pages/en/dev-tools/das-api/getting-started.md
  • src/pages/ja/dev-tools/das-api/core-extension/index.md
  • src/pages/ja/dev-tools/das-api/getting-started.md
  • src/pages/ko/dev-tools/das-api/core-extension/index.md
  • src/pages/ko/dev-tools/das-api/getting-started.md
  • src/pages/zh/dev-tools/das-api/core-extension/index.md
  • src/pages/zh/dev-tools/das-api/getting-started.md

Summary by CodeRabbit

  • New Features

    • Added a “Getting Started” link to the Core Extension SDK navigation.
    • Added a direct anchor for the MPL Core DAS section to enable stable links.
  • Documentation

    • Renamed the Core DAS API page from “Methods” to “Overview.”
    • Clarified package details, supported types, inherited plugin handling, and DAS-to-Core conversion.
    • Added installation and setup links across English, Japanese, Korean, and Chinese documentation.

Walkthrough

Updates Core DAS API navigation and localized documentation. Adds stable anchors to MPL Core DAS sections and revises overview metadata and introductory content to reference the @metaplex-foundation/mpl-core-das package.

Changes

DAS API documentation

Layer / File(s) Summary
Quick-start navigation and anchors
src/components/products/das-api/index.js, src/pages/*/dev-tools/das-api/getting-started.md
Adds a Getting Started navigation entry linking directly to the MPL Core DAS section across English, Japanese, Korean, and Chinese pages.
Localized Core DAS API overviews
src/pages/*/dev-tools/das-api/core-extension/index.md
Changes page titles from methods to overview terminology and updates introductory text with package, type conversion, plugin derivation, and setup references.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: tonyboylehub

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: improving mpl-core-das package visibility on the overview page.
Description check ✅ Passed The description is directly related to the change and explains why the overview page needed the package name.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mpl-core-das-improvements

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant