Skip to content

Post: Copilot Review Prow Plugin - #631

Merged
metal3-io-bot merged 1 commit into
metal3-io:sourcefrom
Nordix:peppi-lotta/copilot-review-prow-plugin
Jun 5, 2026
Merged

Post: Copilot Review Prow Plugin#631
metal3-io-bot merged 1 commit into
metal3-io:sourcefrom
Nordix:peppi-lotta/copilot-review-prow-plugin

Conversation

@peppi-lotta

@peppi-lotta peppi-lotta commented Jun 2, 2026

Copy link
Copy Markdown
Member

Post about Copilot Review Prow Plugin

@netlify

netlify Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for metal3io-website ready!

Name Link
🔨 Latest commit 8cc4b18
🔍 Latest deploy log https://app.netlify.com/projects/metal3io-website/deploys/6a22656b5a380f00082e13a4
😎 Deploy Preview https://deploy-preview-631--metal3io-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 2, 2026
@peppi-lotta
peppi-lotta force-pushed the peppi-lotta/copilot-review-prow-plugin branch 4 times, most recently from bd35103 to 37c9d3d Compare June 2, 2026 08:10
@peppi-lotta

peppi-lotta commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

The pre-commi check failure relates to file _posts/2026-02-01-Deploying_OCI_Images_with_Custom_IPA_Hardware_Manager.md. I think this can be ignored for this PR and we should open a separate fix for it.

@lentzi90 @tuminoid Do you have any additions to this post?

tuminoid
tuminoid reviewed Jun 2, 2026
View reviewed changes
Comment thread _posts/2026-06-02-Copilot-review-prow-plugin.md Outdated
Comment thread _posts/2026-06-02-Copilot-review-prow-plugin.md Outdated
Comment thread _posts/2026-06-02-Copilot-review-prow-plugin.md Outdated
Comment thread _posts/2026-06-02-Copilot-review-prow-plugin.md Outdated
Comment thread _posts/2026-06-02-Copilot-review-prow-plugin.md Outdated
Comment thread _posts/2026-06-02-Copilot-review-prow-plugin.md Outdated
Comment thread _posts/2026-06-02-Copilot-review-prow-plugin.md
Comment thread _posts/2026-06-02-Copilot-review-prow-plugin.md Outdated
@tuminoid tuminoid mentioned this pull request Jun 2, 2026
Closed
@peppi-lotta
peppi-lotta force-pushed the peppi-lotta/copilot-review-prow-plugin branch from 37c9d3d to 1a3f01c Compare June 3, 2026 07:00
lentzi90
lentzi90 reviewed Jun 3, 2026
View reviewed changes

@lentzi90 lentzi90 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Comment thread _posts/2026-06-02-Copilot-review-prow-plugin.md Outdated
@metal3-io-bot

metal3-io-bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026
@peppi-lotta
peppi-lotta force-pushed the peppi-lotta/copilot-review-prow-plugin branch from 1a3f01c to 6a11141 Compare June 3, 2026 09:56
kashifest
kashifest reviewed Jun 4, 2026
View reviewed changes

@kashifest kashifest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2026
tuminoid
tuminoid reviewed Jun 4, 2026
View reviewed changes

@tuminoid tuminoid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, the new iteration looks good!

/lgtm

@lentzi90

lentzi90 commented Jun 4, 2026

Copy link
Copy Markdown
Member

I wonder if the pre-commit bump and format fix also fixed this?
/retest

@tuminoid

tuminoid commented Jun 4, 2026

Copy link
Copy Markdown
Member

I wonder if the pre-commit bump and format fix also fixed this? /retest

I think we need to fix the issue at the other post first. Not sure how that got in, but seems to block still.

@lentzi90

lentzi90 commented Jun 4, 2026

Copy link
Copy Markdown
Member

Yeah. I think the way it got in is that these formatters sometimes decide to change things... Sometimes it randomly reformats the spelling word list for no reason

@peppi-lotta

peppi-lotta commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

I'll open a PR to fix the pre-commit issue

@peppi-lotta
Post: Copilot Review Prow Plugin
8cc4b18 
Signed-off-by: peppi-lotta <peppi-lotta.saari@est.tech>
@peppi-lotta
peppi-lotta force-pushed the peppi-lotta/copilot-review-prow-plugin branch from 6a11141 to 8cc4b18 Compare June 5, 2026 05:58
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2026
@peppi-lotta

peppi-lotta commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

This fix was already in. Rebasing now fixed all issues here

tuminoid
tuminoid reviewed Jun 5, 2026
View reviewed changes

@tuminoid tuminoid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2026
@metal3-io-bot
metal3-io-bot merged commit 9ff7127 into metal3-io:source Jun 5, 2026
14 checks passed
@metal3-io-bot
metal3-io-bot deleted the peppi-lotta/copilot-review-prow-plugin branch June 5, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments
@kashifest kashifest kashifest left review comments
+1 more reviewer
@lentzi90 lentzi90 lentzi90 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peppi-lotta @metal3-io-bot @lentzi90 @tuminoid @kashifest