Make more stuff translatable#601
Draft
reosarevok wants to merge 188 commits into
Draft
Conversation
Add a moderation log to keep track of decisions as well.
It was duplicated and unused on two pages
and add a button to show/hide the password
+ automatic formating
Fix form validation and UI hints, rework the UI to be more user-friendly, cleanup markup, make it more mobile friendly
same as other pages, big call-to-action button as in the design files
We don't want end-users to create accounts directly on MeB.org, but it might just happen, so adding a link to the signup page they would be looking for.
Otherwise the entire test suite fails
…rotection to admin forms, and fixed moderation commit handling
It looks like this was intended to be used for a tier upgrade process, but we currently just do that by letting the user mail us. is_upgrade does not seem to be set anywhere in the codebase.
Otherwise we are promising more than we should.
As worded this suggests we would block access to all our APIs, but most of them are public. This seems to be meant specifically for the replication API only.
This seems to not change the meaning at all, but require double the translator effort.
We have received several checks every year, including some for thousands of dollars - we should not say we don't accept them entirely, but we should discourage their use. For what it's worth, we pay $10 or more in fees every time we make someone go to the bank and cash a check for us.
reosarevok
requested review from
MonkeyDo and
amCap1712
and removed request for
amCap1712
July 16, 2026 15:19
Test Results401 tests 386 ✅ 3m 21s ⏱️ For more details on these failures, see this check. Results for commit 49fbddd. ♻️ This comment has been updated with latest results. |
reosarevok
force-pushed
the
make-stuff-translatable
branch
5 times, most recently
from
July 17, 2026 14:10
8c5e57b to
305b56f
Compare
This changes to an unicode apostrophe since it seemed clearer than just escaping it here.
We already do so for "Commercial".
Without that the order wouldn't make sense in many languages.
This makes it a lot more clear for translation.
These are otherwise almost entirely untranslateable.
This makes it a lot more clear for translation.
reosarevok
force-pushed
the
make-stuff-translatable
branch
from
July 17, 2026 14:35
305b56f to
49fbddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please double check if this is the right way to do these things - I've aped what I saw @MonkeyDo do for the combined strings. I checked locally and they seem to work, anyway. I also made some big policy docs translatable, moved the URLs into variables but not quite sure what to do if anything with the email addresses.