SEARCH-444, SEARCH-752, SEARCH-753: Breaking changes to relationship JSON#69
Open
mwiencek wants to merge 8 commits into
Open
SEARCH-444, SEARCH-752, SEARCH-753: Breaking changes to relationship JSON#69mwiencek wants to merge 8 commits into
mwiencek wants to merge 8 commits into
Conversation
…d work JSON The `target-type` is also missing from area and URL relationships, but this commit only affects event and work relationships. Extending the `RelationAdapter` usage to areas and URLs would add the `target-type` but also fix SEARCH-444, which is a larger breaking change.
Adds an adapter based on WorkAdapter.java to flatten the relation lists into a single `relations` array. This also fixes SEARCH-753 for areas only.
Adds an adapter based on WorkAdapter.java to flatten the relation lists into a single `relations` array. This also fixes SEARCH-753 for URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #68.
Fixes the following issues:
relation-listin `area’ and ‘url’ JSON outputtargetproperty in JSON outputtarget-typeproperty in relationships of ‘area’ and ‘url’ JSON outputSince SEARCH-444 changes the relationship list structure for areas and URLs, and SEARCH-752 removes an existing property, these are intended to be announced and released as part of the schema change.
SEARCH-753 is included because it depends on SEARCH-444, and is already being fixed for events and works prior to the schema change in #68.