Repository navigation
[Nexthop][misc] Remove dead VLAN neighbor update functions and unused includes - #1905
Closed
benoit-nexthop wants to merge 1 commit into
Closed
benoit-nexthop wants to merge 1 commit into
benoit-nexthop wants to merge 1 commit into
Conversation
getUpdateFnToProgramEntryForVlan() and getUpdateFnToProgramPendingEntryForVlan() lost their last callers when FLAGS_intf_nbr_tables was removed from NeighborCacheImpl-defs.h (8b49d2f); every neighbor update now goes through the interface table variants. Drop both functions. Also drop the includes clang-tidy's misc-include-cleaner reports as unused in NeighborCacheImpl.h, NeighborCacheImpl-defs.h and SwSwitchTest.cpp. NeighborCacheImpl-defs.h throws FbossError itself, so it now includes FbossError.h directly instead of through NeighborCacheImpl.h.
Contributor
|
@KevinYakar has imported this pull request. If you are a Meta employee, you can view this in D129483370. |
Contributor
|
@KevinYakar merged this pull request in fb69397. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NeighborCacheImpl::getUpdateFnToProgramEntryForVlan()andgetUpdateFnToProgramPendingEntryForVlan()have had no callers since 8b49d2f ("Remove FLAGS_intf_nbr_tables from NeighborCacheImpl-defs.h"), which removed the VLAN-table branch ofprogramEntry()/programPendingEntry(). Every neighbor update now goes throughgetUpdateFnToProgramEntry()/getUpdateFnToProgramPendingEntry(). This removes both dead functions.It also removes the includes that clang-tidy's
misc-include-cleanerreports as unused inNeighborCacheImpl.h,NeighborCacheImpl-defs.handSwSwitchTest.cpp.NeighborCacheImpl-defs.hthrowsFbossErroritself, so it now includesFbossError.hdirectly instead of getting it throughNeighborCacheImpl.h.We checked with Meta that neither function has callers in the internal code base either.
This touches the same function as #1903, which changes its lambda captures. Whichever of the two lands second needs a trivial rebase (keep the deletion).
Test Plan
The equivalent change in our internal tree passed our CI's Bazel build and its cmake build + unit test run (clang). No reference to either removed function remains in the tree.
Review Findings
No issues found above confidence threshold (fboss-review, 7 applicable reviewers).