Skip to content

qrencode: add 4.1.1#1277

Merged
neheb merged 2 commits into
mesonbuild:masterfrom
hrxi:pr_qrencode
Nov 10, 2023
Merged

qrencode: add 4.1.1#1277
neheb merged 2 commits into
mesonbuild:masterfrom
hrxi:pr_qrencode

Conversation

@hrxi

@hrxi hrxi commented Nov 5, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@neheb

neheb commented Nov 5, 2023

Copy link
Copy Markdown
Collaborator

weird that clang-cl builds but not cl...

@hrxi

hrxi commented Nov 6, 2023

Copy link
Copy Markdown
Contributor Author

It's a problem of missing __declspec(dllexport), I believe.

@neheb

neheb commented Nov 6, 2023

Copy link
Copy Markdown
Collaborator

Yeah need to add a def file.

They're needed to make MSVC export symbols from DLLs.
@hrxi

hrxi commented Nov 10, 2023

Copy link
Copy Markdown
Contributor Author

Also opened an upstream PR fixing MSVC support properly: fukuchi/libqrencode#214.

@neheb neheb merged commit d6c1261 into mesonbuild:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants