Stop passing link arguments to compile-only sanity checks - #16142
Closed
tristan957 wants to merge 1 commit into
Closed
Stop passing link arguments to compile-only sanity checks#16142tristan957 wants to merge 1 commit into
tristan957 wants to merge 1 commit into
Conversation
Member
Author
|
Blocker for #15714. |
Member
Author
|
FWIW, I think this is kind of hacky. I would like to split this idiom where we return linker and compiler flags in one function call. I'll propose it on Matrix/IRC for a future improvement. |
Member
There is no need to pass link-only arguments where we are only compiling. This has led to real world issues: Clang will emit a warning when unused arguments are passed on the command line: clang: warning: argument unused during compilation: '-L/tmp/opencode' [-Wunused-command-line-argument] This is a bit of a hard warning to trigger. The following is required: 1. Clang or Clang-derived compiler (clang-cl) 2. A cross build 3. No exe wrapper configured 4. c_link_args is non-empty When (2) and (3) hold, the compile mode becomes CompileCheckMode.COMPILE, which means we pass -c to clang's sanity check command. When -c is passed to clang, it ignores linker arguments like -L. Signed-off-by: Tristan Partin <tristan@partin.io>
tristan957
force-pushed
the
unused-arg-warning
branch
from
August 27, 2026 16:32
d2abac3 to
183b6ab
Compare
tristan957
changed the title
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to pass link-only arguments where we are only compiling. This has led to real world issues:
Clang will emit a warning when unused arguments are passed on the command line:
This is a bit of a hard warning to trigger. The following is required:
When (2) and (3) hold, the compile mode becomes CompileCheckMode.COMPILE, which means we pass -c to clang's sanity check command. When -c is passed to clang, it ignores linker arguments like -L.