Make strict_optional opt out for mesonbuild, not opt in - #15954
Open
bonzini wants to merge 9 commits into
Open
Conversation
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
mypy is now able to deal with extra optional arguments. Also export env_validator instead of fishing it out of ENV_KW. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
bonzini
force-pushed
the
mypy-strict-optional
branch
from
August 11, 2026 11:59
9ab76ec to
4ba2a06
Compare
bonzini
marked this pull request as ready for review
August 11, 2026 12:32
bonzini
force-pushed
the
mypy-strict-optional
branch
from
August 11, 2026 14:28
4ba2a06 to
f7b45d1
Compare
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
There are roughly 70 modules that fail mypy without implicit optional, versus 200 that do. mesonbuild.compilers is the only one that is uniformly pretty bad; mesonbuild.dependencies comes close but a lot of modules have only 1-2 failures. List everything else in .mypy.ini one by one. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
bonzini
force-pushed
the
mypy-strict-optional
branch
from
August 11, 2026 20:07
f7b45d1 to
206652c
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not too interested in getting this forward, but I can at least try to avoid making it worse.
Fix some of the lowest hanging fruit and list all failing modules in
.mypy.ini.Here are the remaining files with 10 or less errors (80% of the files, 25% of the errors):
The worst offenders (10% of the files, 50% of the issues) are
and it's likely that something clever will fix most of the issues.