uninstall: handle elevation to root like minstall - #13948
Open
rmader wants to merge 1 commit into
Open
Conversation
For better consistency and because it can often come in handy.
Contributor
|
Can you rebase and fix the linters? |
Contributor
|
@rmader ping ^ |
Contributor
|
Two changes are needed:
|
eli-schwartz
requested changes
Mar 4, 2026
eli-schwartz
left a comment
eli-schwartz
left a comment
Member
There was a problem hiding this comment.
There's a rather bigger problem, which is that we have two copies of the same code now. We should instead have uninstall, import it from mesonbuild.minstall.
Contributor
|
@rmader can you have a look at sharing the code between install and uninstall? |
Author
|
I'll try to get back to this in the coming days! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better consistency and because it can often come in handy.
Supersedes #8846 by following the approach of #11366