Skip to content

ENH: warn on unhandled meson install arguments - #797

Merged
rgommers merged 1 commit into
mesonbuild:mainfrom
dnicolodi:meson-install-args
Oct 23, 2025
Merged

ENH: warn on unhandled meson install arguments#797
rgommers merged 1 commit into
mesonbuild:mainfrom
dnicolodi:meson-install-args

Conversation

@dnicolodi

Copy link
Copy Markdown
Member

No description provided.

@rgommers

Copy link
Copy Markdown
Contributor

Is this asymmetric between install vs. setup/compile/dist on purpose?

@dnicolodi

Copy link
Copy Markdown
Member Author

meson-python actually runs meson {setup,compile,dist} thus if the passed arguments are not valid, the build fails. However, meson install is never executed and meson-python directly interprets the arguments. meson-python does not implement all the arguments supported by meson install. So far meson python ignored the arguments it does not recognize, but this is problematic for two reasons: it makes spotting typos in supported arguments much harder, and there is no easy way to discover unsupported arguments. We can error our on unrecognized arguments, but it may cause forward compatibility issues for project that have been passing invalid arguments unnoticed.

@rgommers rgommers added the enhancement New feature or request label Oct 23, 2025
@rgommers rgommers added this to the v0.19.0 milestone Oct 23, 2025

@rgommers rgommers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, that's a good rationale. In it goes, thanks @dnicolodi!

@rgommers
rgommers merged commit 661312e into mesonbuild:main Oct 23, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants