Skip to content

Remove python-ajsonrpc and python-platformio packages#79

Merged
vidplace7 merged 1 commit into
mainfrom
upstream-remove-pio
Jun 30, 2026
Merged

Remove python-ajsonrpc and python-platformio packages#79
vidplace7 merged 1 commit into
mainfrom
upstream-remove-pio

Conversation

@vidplace7

@vidplace7 vidplace7 commented Jun 30, 2026

Copy link
Copy Markdown
Member

Added upstream, no longer needed here.

Summary by CodeRabbit

  • Chores
    • Removed build definitions for two Python-related packages, so they are no longer included as available package options.
    • Cleaned up associated package metadata, descriptions, and build declarations.

Added upstream, no longer needed here.
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9e8cc799-d5bc-4f7a-b0b2-3a87ccac07ed

📥 Commits

Reviewing files that changed from the base of the PR and between 602fa8b and c7023d1.

📒 Files selected for processing (2)
  • depends/python-ajsonrpc/Makefile
  • depends/python-platformio/Makefile
💤 Files with no reviewable changes (2)
  • depends/python-platformio/Makefile
  • depends/python-ajsonrpc/Makefile

📝 Walkthrough

Walkthrough

Two OpenWrt build recipe Makefiles are deleted: depends/python-ajsonrpc/Makefile (46 lines) and depends/python-platformio/Makefile (80 lines). Both files contained package metadata, dependency declarations, package descriptions, and Py3Package/BuildPackage/HostBuild invocations.

Changes

Cohort / File(s) Summary
Removed package recipes
depends/python-ajsonrpc/Makefile, depends/python-platformio/Makefile
Both Makefiles deleted entirely, removing OpenWrt python3-ajsonrpc and python3-platformio package definitions, metadata, and build rule invocations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • meshtastic/openwrt#78: Directly modifies the same depends/python-ajsonrpc/Makefile and depends/python-platformio/Makefile package recipes that this PR deletes.

Poem

Two Makefiles gone, poof, into the air,
No more ajsonrpc, no platformio there,
The bunny hops on with a lighter load,
Cleaning the depends along the road,
🐇✨ Less is more, says the code!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the removal of the two Python packages from the repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@vidplace7
vidplace7 merged commit 98f9ea9 into main Jun 30, 2026
11 checks passed
@vidplace7
vidplace7 deleted the upstream-remove-pio branch June 30, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant