Skip to content

fix: avoid double-closing serial transport #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eburi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid double-closing serial transport #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions custom_components/meshtastic/aiomeshtastic/connection/serial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import contextlib
import re
from asyncio import StreamReader, StreamReaderProtocol, StreamWriter
from typing import cast

import serial
import serial_asyncio
Expand Down Expand Up @@ -86,7 +85,6 @@ async def read_log(reader: StreamReader) -> None:
async def _disconnect(self) -> None:
if self._writer:
self._writer.close()
cast("serial_asyncio.SerialTransport", self._writer.transport).serial.close()
self._writer = None
self._reader = None

Expand Down