feat(eventFirmware): DEF CON 34 branding icon - #109
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe DEFCON 34 event firmware entry now specifies its icon resource URL instead of ChangesDEFCON icon metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 28, 2026
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 Why
DEFCONis the next event edition to go live (2026-08-06), and it is the only near-term edition still servingiconUrl: null. Clients that render event branding — the Android app's app bar and event info sheet — fall back to the generic Meshtastic logo, so a device flashed with DEF CON firmware looks identical to one that is not.The manifest already carries DEF CON's full theme (palette, named colors, "Agency", the tagline, Lato / Atkinson Hyperlegible). The icon was the only piece missing.
🛠️ What
static/eventFirmware/defcon34.png— the DEF CON 34 mark, 384×384, quantized to 64 colors (18.6 KB, RMSE 1.1% against the source). Sits alongsidehamvention.pngandfab26.pngand is served by the existingresource/eventFirmware/:fileroute unchanged.DEFCONedition'siconUrltohttps://api.meshtastic.org/resource/eventFirmware/defcon34.png.No route, schema, or serving changes — this is the case
eventFirmwareIcon.tswas written for.🧪 Testing performed
data/eventFirmware.jsonre-parses; every other edition'siconUrlis byte-identical (only theDEFCONvalue changed).📝 Note for maintainers
The artwork is DEF CON's, used here to identify their event. Worth a nod from DEF CON before this ships if that relationship isn't already covered by the event-firmware collaboration.
🤖 Generated with Claude Code
Summary by CodeRabbit