Skip to content

feat(eventFirmware): DEF CON 34 branding icon - #109

Merged
jamesarich merged 2 commits into
masterfrom
defcon34-icon
Jul 28, 2026
Merged

feat(eventFirmware): DEF CON 34 branding icon#109
jamesarich merged 2 commits into
masterfrom
defcon34-icon

Conversation

@jamesarich

@jamesarich jamesarich commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🌟 Why

DEFCON is the next event edition to go live (2026-08-06), and it is the only near-term edition still serving iconUrl: null. Clients that render event branding — the Android app's app bar and event info sheet — fall back to the generic Meshtastic logo, so a device flashed with DEF CON firmware looks identical to one that is not.

The manifest already carries DEF CON's full theme (palette, named colors, "Agency", the tagline, Lato / Atkinson Hyperlegible). The icon was the only piece missing.

🛠️ What

  • Add static/eventFirmware/defcon34.png — the DEF CON 34 mark, 384×384, quantized to 64 colors (18.6 KB, RMSE 1.1% against the source). Sits alongside hamvention.png and fab26.png and is served by the existing resource/eventFirmware/:file route unchanged.
  • Set the DEFCON edition's iconUrl to https://api.meshtastic.org/resource/eventFirmware/defcon34.png.

No route, schema, or serving changes — this is the case eventFirmwareIcon.ts was written for.

🧪 Testing performed

  • data/eventFirmware.json re-parses; every other edition's iconUrl is byte-identical (only the DEFCON value changed).
  • Icon renders correctly at 32 dp and 48 dp circle-clipped, which is how clients present it.

📝 Note for maintainers

The artwork is DEF CON's, used here to identify their event. Worth a nod from DEF CON before this ships if that relationship isn't already covered by the event-firmware collaboration.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Added the correct DEF CON 34 event icon for improved display in the application.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 296ecd99-e8f7-47f6-842d-666fd4782c86

📥 Commits

Reviewing files that changed from the base of the PR and between 97eca8a and c76a1df.

⛔ Files ignored due to path filters (1)
  • static/eventFirmware/defcon34.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • data/eventFirmware.json

📝 Walkthrough

Walkthrough

The DEFCON 34 event firmware entry now specifies its icon resource URL instead of null.

Changes

DEFCON icon metadata

Layer / File(s) Summary
Update DEFCON icon URL
data/eventFirmware.json
Sets the DEFCON entry’s iconUrl to the defcon34.png resource URL.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: thebentern

Poem

A bunny found an icon bright,
For DEFCON’s banner in the night.
One URL hopped into place,
Giving the event a pictured face.
Carrot cheers and pixels gleam!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant