Conversation
handleCommand() (reached via CMD_RUN_CLI_COMMAND, used by BLE/WiFi/USB companion clients) had no "reboot" branch, so it replied "Unknown command". CMD_REBOOT (a separate binary opcode) and checkCLIRescueCmd()'s own special-cased reboot handling both bypass handleCommand() entirely, so this gap was never noticed on those paths. Matches the existing convention elsewhere (checkCLIRescueCmd()): calls board.reboot() directly, no reply attempted since it doesn't return. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
|
Hey there! Thanks for the PR! I'm opting to merge in my PR #3442 instead, to avoid all the AI generated comments, and also add the shutdown/poweroff commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
rebootbranch tohandleCommand()(the text dispatcher reached viaCMD_RUN_CLI_COMMAND, used by BLE/WiFi/USB companion clients).Why
handleCommand()had norebootbranch, so sendingrebootover this path replied "Unknown command".CMD_REBOOT(a separate binary opcode) andcheckCLIRescueCmd()'s own special-casedreboothandling both bypasshandleCommand()entirely, so this gap was never noticed on those paths.How
Matches the existing convention elsewhere (
checkCLIRescueCmd()): callsboard.reboot()directly, no reply attempted since it doesn't return.Compile-verified against current
dev(heltec_v4_companion_radio_ble).🤖 Generated with Claude Code