Conversation
JohannesRudolph
approved these changes
Apr 24, 2025
| ARG UID=1005 | ||
|
|
||
| COPY --from=builder /build/build/libs/unipipe-service-broker-1.0.0.jar /app/ | ||
| COPY --chown=0:0 --chmod=555 --from=builder /build/build/libs/unipipe-service-broker-1.0.0.jar /app/ |
Member
There was a problem hiding this comment.
can the chown command in the COPY and in the RUN instruction below be combined into the COPY instruction already?
Author
There was a problem hiding this comment.
No not really, the idea was that the jar is owned by root and can only be executed (not modified) by other users. While the /app itself must be writeable for the unprivileged container user, which runs the jar as it writes the SSH key into the /app/tmp directory (and also creates the /app/tmp directory after #139 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is considered bad practice to let applications run as root in a Docker container. Furthermore, this might even be prohibited in some environments. In order to lower the attack surface, the application is executed as an unprivileged user with this PR.