Conversation
JohannesRudolph
requested changes
Apr 24, 2025
| .apply { | ||
| remote = "origin" | ||
|
|
||
| gitConfig.username?.let { |
Member
There was a problem hiding this comment.
discuss: for my taste we started copy/pasting this around a a little too much by now and i think it makes sense to move this into a common method called by all git operations (so we don't miss HTTPS basic auth support on other git operations by accident)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Git over HTTP(s) for the remote Git repo, there was no credential provider for the
fetchMergePushfunction. Thus those operations would fail for repositories requiring authentication. See the log output:This PR fixes this.