Skip to content

Security fix: gitlab.bandit.B602 in src/dummy_vulnerable_app.py #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devsecops-ai-integration-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Security fix: gitlab.bandit.B602 in src/dummy_vulnerable_app.py #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/dummy_vulnerable_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,10 @@ def run_ping(host):

def run_backup(user_supplied_path):
# Vulnerability: command injection with subprocess.Popen and shell=True.
return subprocess.Popen("tar czf backup.tgz " + user_supplied_path, shell=True)
# Fixed: changed shell=True to shell=False and used shlex.split to safely handle user input.
import shlex
command = ["tar", "czf", "backup.tgz", shlex.quote(user_supplied_path)]
return subprocess.Popen(command, shell=False)


def run_admin_task(task_name):
Expand Down
Loading