Bugfix: interval attribute and Chore: update tooling to 2.2.5#23
Open
tieniber wants to merge 5 commits into
Open
Bugfix: interval attribute and Chore: update tooling to 2.2.5#23tieniber wants to merge 5 commits into
tieniber wants to merge 5 commits into
Conversation
this._intervalChange was not called with the correct parameter, resulting in incorrect behavior when changing the interval dynamically.
Contributor
|
@tieniber do you still need those changes? Why the gulp file is changed so much? |
leonardomendix
previously approved these changes
Sep 29, 2020
leonardomendix
left a comment
leonardomendix
left a comment
Contributor
There was a problem hiding this comment.
Tested and it works as expected.
Member
Author
|
I do still think these changes should be merged, because they are required in order to be able to control the timer interval dynamically. The gulpfile changed significantly because I also upgraded the tooling to generator-mendix@2.2.5 I will rebase ASAP. |
Contributor
|
@tieniber any changes here? |
Contributor
|
@tieniber i am not sure if the dependency changes + gulp is relevant for this PR as your change actually is 1 line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in the interval attribute subscription that made it unable to be changed on the fly, and updating to v2.2.5 of the generator