Skip to content

added German translation, updated README and removed memory management - #2

Open
shezi wants to merge 3 commits into
memmons:masterfrom
shezi:master
Open

added German translation, updated README and removed memory management#2
shezi wants to merge 3 commits into
memmons:masterfrom
shezi:master

Conversation

@shezi

@shezi shezi commented Feb 2, 2012

Copy link
Copy Markdown

There are actually three things in this pull request:

  1. German translations: You can pull this safely, as I am native German.
  2. updated README: The README associated with this repository did not reflect the change introduced in ff607a2, whereafter one has to explicitly call -showPromptIfNeeded to get the dialog on the screen.
  3. The third thing is a bit more problematic: I removed all memory management code. In iOS 5 with ARC, this is not necessary any more. I tested it and it looks good. Also, it should be compatible with iOS 4.3, as there were no __weak references, but I couldn't test that. In any case, this change should only be merged if all developers use XCode 4.2 and at least iOS 4.3

@shezi

shezi commented Feb 2, 2012

Copy link
Copy Markdown
Author

You can't use autorelease in an ARC build, however. I looked for some kind of compiler switch to determine whether this was needed or not, but I couldn't find any.

One solution would be to indicate that in iOS 5 builds, the file needs to be excluded from the ARC. This is possible, via http://developer.apple.com/library/mac/#releasenotes/ObjectiveC/RN-TransitioningToARC/_index.html

@memmons

memmons commented Feb 2, 2012

Copy link
Copy Markdown
Owner

Using conditional builds is getting way more complicated than is needed for this. It could be as simple as changing the alertImageView to this:

 UIImageView *alertImageView = [[[UIImageView alloc] initWithImage:alertImage] autorelease] ;

The only reason I'm not proposing that immediately is because I recall some issues using autorelease on the image that is being inserted (hacked) into the UIAlertView. I'll need to test for breakage and memory issues before making the change.

Assuming I can make that change then I can also get rid of the autorelease pool as well -- which should make everything arc compliant.

@shezi

shezi commented Feb 2, 2012

Copy link
Copy Markdown
Author

I didn't know that was possible in ARC. I'm looking very much forward to your solution!

@shezi

shezi commented Apr 26, 2012

Copy link
Copy Markdown
Author

Any changes on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants