Remove legacy test

[christiangoerdes]

Summary by CodeRabbit

• Chores

  • Added Apache License 2.0 headers to multiple source and test files.
  • Removed obsolete test configuration resources and test classes.

• Tests

  • Updated test expectations for access control examples.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request adds Apache 2.0 license headers to multiple Java source and test files in the ACL interceptor module, removes an obsolete test file and test resource configuration, and updates test assertions in an ACL example test.

Changes

Cohort / File(s)	Summary
License Headers - ACL Interceptor (Production) core/src/main/java/com/predic8/membrane/core/interceptor/acl/AccessControl.java, AccessControlInterceptor.java, IpAddress.java, PeerAddressResolver.java, rules/AccessRule.java, rules/Allow.java, rules/Deny.java, targets/HostnameTarget.java, targets/Ipv4Target.java, targets/Ipv6Target.java, targets/Target.java	Added Apache 2.0 license header to top of each file; no functional changes to class structure, methods, or APIs.
License Headers - Balancer core/src/main/java/com/predic8/membrane/core/interceptor/balancer/ExchangeNodeStatusTracker.java	Added Apache 2.0 license header; no behavioral changes.
License Headers - Test Files core/src/test/java/com/predic8/membrane/core/interceptor/acl/AccessControlInterceptorTest.java, AccessControlTest.java, IpAddressTest.java, targets/HostnameTargetTest.java, targets/Ipv4TargetTest.java, targets/Ipv6TargetTest.java, targets/TargetTest.java, targets/TargetUtilTest.java	Added Apache 2.0 license header to each test file; no changes to test logic or assertions.
Deleted Test Configuration core/src/test/java/com/predic8/membrane/core/config/ReadRulesWithInterceptorsConfigurationTest.java	Removed entire test class that verified proxy rules and interceptor configurations. Previously contained setup/teardown methods and tests for rule count, interceptor count, and interceptor reference validation.
Deleted Test Resource core/src/test/resources/ref.proxies.xml	Removed Spring bean configuration file containing router, serviceProxy, proxy definitions and interceptor bean definitions (roundRobinBalancer, byThreadBalancer, accessControlInterceptor, administratorInterceptor).
Updated Test Assertions distribution/src/test/java/com/predic8/membrane/examples/withinternet/test/ACLExampleTest.java	Changed endpoint test expectations: /contacts/ (404) → /products/ (200); /open-source/ (401) → /vendors/ (403).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Outgoing api gateway example #2072: Modifies ReadRulesWithInterceptorsConfigurationTest.java while this PR deletes the same test file entirely.

Suggested labels

7.x

Suggested reviewers

• rrayst
• predic8

Poem

🐰 License headers hop in line,
Old configs bundled, files combine,
Tests deleted, assertions bright,
A cleanup done with rabbit's might! ✨

✨ Finishing touches

• 📝 Generate docstrings

---

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f2f5e73 and da20306.

📒 Files selected for processing (23)

• core/src/main/java/com/predic8/membrane/core/interceptor/acl/AccessControl.java
• core/src/main/java/com/predic8/membrane/core/interceptor/acl/AccessControlInterceptor.java
• core/src/main/java/com/predic8/membrane/core/interceptor/acl/IpAddress.java
• core/src/main/java/com/predic8/membrane/core/interceptor/acl/PeerAddressResolver.java
• core/src/main/java/com/predic8/membrane/core/interceptor/acl/rules/AccessRule.java
• core/src/main/java/com/predic8/membrane/core/interceptor/acl/rules/Allow.java
• core/src/main/java/com/predic8/membrane/core/interceptor/acl/rules/Deny.java
• core/src/main/java/com/predic8/membrane/core/interceptor/acl/targets/HostnameTarget.java
• core/src/main/java/com/predic8/membrane/core/interceptor/acl/targets/Ipv4Target.java
• core/src/main/java/com/predic8/membrane/core/interceptor/acl/targets/Ipv6Target.java
• core/src/main/java/com/predic8/membrane/core/interceptor/acl/targets/Target.java
• core/src/main/java/com/predic8/membrane/core/interceptor/balancer/ExchangeNodeStatusTracker.java
• core/src/test/java/com/predic8/membrane/core/config/ReadRulesWithInterceptorsConfigurationTest.java
• core/src/test/java/com/predic8/membrane/core/interceptor/acl/AccessControlInterceptorTest.java
• core/src/test/java/com/predic8/membrane/core/interceptor/acl/AccessControlTest.java
• core/src/test/java/com/predic8/membrane/core/interceptor/acl/IpAddressTest.java
• core/src/test/java/com/predic8/membrane/core/interceptor/acl/targets/HostnameTargetTest.java
• core/src/test/java/com/predic8/membrane/core/interceptor/acl/targets/Ipv4TargetTest.java
• core/src/test/java/com/predic8/membrane/core/interceptor/acl/targets/Ipv6TargetTest.java
• core/src/test/java/com/predic8/membrane/core/interceptor/acl/targets/TargetTest.java
• core/src/test/java/com/predic8/membrane/core/interceptor/acl/targets/TargetUtilTest.java
• core/src/test/resources/ref.proxies.xml
• distribution/src/test/java/com/predic8/membrane/examples/withinternet/test/ACLExampleTest.java

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}