Skip to content

expose beanRegistry for scripting - #2598

Merged
predic8 merged 3 commits into
masterfrom
expose-registry
Jan 13, 2026
Merged

expose beanRegistry for scripting#2598
predic8 merged 3 commits into
masterfrom
expose-registry

Conversation

@christiangoerdes

@christiangoerdes christiangoerdes commented Jan 12, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Scripting environment now exposes the registry alongside existing script bindings.
  • Documentation

    • Roadmap formatting corrected and the prior “Scripting: expose beanRegistry” note removed for clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 12, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

A single line was added to scripting parameter bindings inserting a registry entry with router.getRegistry(), exposing the registry to scripting contexts alongside existing bindings.

Changes

Cohort / File(s) Summary
Registry Parameter Exposure
core/src/main/java/com/predic8/membrane/core/lang/ScriptingUtils.java
Inserted "registry" into the scripting parameters map with router.getRegistry() so scripts can access the registry.
Docs: Roadmap Cleanup
docs/ROADMAP.md
Adjusted log subsection formatting and removed the "Scripting: expose beanRegistry" roadmap entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • predic8
  • t-burch
  • rrayst

Poem

🐰 I found a tiny hop in code,
A registry now lightens the load,
Scripts can greet it on their road,
One line added — off we go! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'expose beanRegistry for scripting' directly and concisely describes the main change: exposing the registry in the scripting environment.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1ea264 and f3d2e3f.

📒 Files selected for processing (1)
  • docs/ROADMAP.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/ROADMAP.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@membrane-ci-server

Copy link
Copy Markdown

This pull request needs "/ok-to-test" from an authorized committer.

@predic8
predic8 merged commit 32058dd into master Jan 13, 2026
4 of 5 checks passed
@predic8
predic8 deleted the expose-registry branch January 13, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants