Remove the manual application option for hints yaml - #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes support for user-supplied YAML hints ("hint.yaml") from Threat Thinker, shifting the workflow to rely solely on LLM-inferred attribute inference and business context for diagram analysis. Documentation, CLI, code, and examples have been updated to reflect this change, and references to hints and hint files have been removed throughout the project.
Major changes include:
Removal of Hint YAML Support
docs/hints.mdguide, all references to "hint.yaml", and the--hintsCLI argument and processing logic from the codebase, including theapply_hintsfunction and related UI steps. Example hint files inexamples/diagrams/web/hint.yamlandexamples/diagrams/aws/hint.yamlwere also removed. [1] [2] [3] [4] [5] [6] [7] [8]Documentation and Tutorial Updates
docs/README.md,docs/diagram.md,docs/design.md,docs/cli.md,docs/troubleshooting.md,docs/tutorials.md) to remove or revise all mentions of hints, hint files, and hint-related CLI flags. Guidance now emphasizes using LLM-inferred attributes and business context for customizing analysis. [1] [2] [3] [4] [5] [6] [7] [8]CLI and Example Cleanup
--hintsargument and related examples from CLI help, usage, and code (src/threat_thinker/main.py). Progress tracking and UI steps were adjusted to reflect the new workflow without hint application. (F8cbae7fL13R13, [1] [2] [3]Dependency Update
pyamltoPyYAMLinpyproject.tomlfor consistency and standardization.Codebase Refactoring
apply_hintsfunction and all imports/usages of it fromsrc/threat_thinker/hint_processor.pyandsrc/threat_thinker/main.py. The code now exclusively uses LLM-inferred attribute merging. [1] [2] F8cbae7fL55R55)These changes streamline the user experience and codebase by focusing on LLM-powered attribute inference and business context, eliminating the need for manual YAML hint files.