Repository navigation
ci(lychee-online): drop the repo suffix and skip eval cases in claude-code-plugins - #990
Conversation
…-code-plugins The claude-code-plugins online link check has failed every run since 2026-10-11. In run 42809150911, 40 of its 63 dead-link locations were in eval case prompts and graders, which cite made-up URLs by design (x.com/fakehandle/..., attacker.tld, corp.internal). Exclude every plugins/<p>/[skills/<s>/]evals/ tree, which also covers the attribution golden fixtures the old exclude named. Rename the workflow to "Maintenance Check Links Online": workflow names carry no repository suffix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed No findings. I reviewed the one changed file,
I did not run lychee or the regex against the consuming repository's file tree. The PR's claims about the 40 of 63 dead-link locations and the Observation, not a finding: the destination path in |
|
claude-security-review reviewed No security findings. The diff changes one file,
Neither edit touches a trust control. Both fall outside the skip-gate carve-outs, so the full review applied.
I did not read PR context, settled-thread or prior-findings files, because the wrapper supplied none. critical-findings: 0 |
No related issue: owner decision Q14 (failing workflows)
Summary
The claude-code-plugins online link check has failed every run in its history (last 10: all failure, latest run 42809150911). In that run, 40 of the 63 dead-link locations were eval case prompts and graders that cite made-up URLs by design (
x.com/fakehandle/...,attacker.tld,sms-admin.corp.internal,github.com/acme/...). The workflow name also carries the repository name, which the naming decision drops.Fix
plugins/<p>/[skills/<s>/]evals/tree from the online check. This replaces the old exclude for the attribution golden fixtures, which sits inside one of those trees.The remaining dead links are real and are fixed in claude-code-plugins itself. That repository's
maintenance-file-dead-links.ymltriggers on this workflow'sname:; the claude-code-plugins fix PR adds the new name to its trigger, so it should land before the sync PR that carries this rename.Verification
git ls-files 'plugins/**/*.md' | grep -E '^plugins/[^/]+/.+/evals/' | grep -vE '^plugins/[^/]+/(skills/[^/]+/)?evals/'prints nothing), andplugins/evals/(a plugin named evals) is not matched.link-check-online-dead-linksartifact match the regex.Related
maintenance-file-dead-links.ymltrigger), linked once opened.🤖 Generated with Claude Code
https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe