Repository navigation
feat(github-actions-conventions): admit claude-code-plugins' workflow names - #984
Merged
Merged
Conversation
…ames
naming-lint gains three rules and tightens one:
- job-name: every job has a Title Case display name, separate from its
id; expressions keep their place ("Drift (${{ matrix.skill }})"). The
ci-status job is named exactly "CI Status", and the report-ci-status
alias job keeps the required context "ci-status" until the github-iac
ci-gate ruleset requires "CI Status" (jobNameExceptions).
- step-name: step names are sentence case, as GitHub's own steps are;
a later capitalized word must be in the new properNouns list, an
acronym or a mixed-case name.
- action-name: an action's name is its directory's Title Case form.
- workflow-name: accepts the Title Case form only (or a recorded
exception); the bare stem no longer passes.
job-name and step-name report at the vocabulary's displayNameLevel,
warning for now: ci-workflows runs the analyzer from standards main,
so error would block it before its jobs are named. The README replaces
"never rename ci-status" with the three-step rename the alias supports.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe
… names claude-code-plugins cannot run naming-lint enforcing today: 20 blocking findings, every one a file or action-directory name. Fourteen are verb-first names whose words the vocabulary lacked, so this adds the function words (intake reenter; maintenance audit-lane-runs, check-upstream-drift, delete-stale-branches, file-dead-links, file-recurring-issues, monitor-signals, reconcile-lost-runs; post-merge select-mutation-range, test-mutation; pr rate-merge-risk) and the verbs delete, log, monitor, open, rate, reenter and seal. The other six need renames, tracked in melodic-software/claude-code-plugins#15394; each gets a repository-scoped workflow-filename exemption naming that issue, so every other rule still applies to them. The README's exemptions section now describes both kinds of entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe
Review fixes for #983: - step-name removed a multi-word proper noun before tokenizing, so the word after a leading "Claude Code" or "Pulumi Cloud" became the first word and escaped the capitalization check ("Claude Code Review" passed). Tokens now keep their positions; a multi-word noun exempts its words only where they appear together, so "Code" alone is no longer exempt either. - The README's display-name rollout links its completion issue, standards#985, due 2026-12-11, as the enforcement rollout requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe
…at/naming-vocab-ccp-adoption
The org job-name rule (#983) wants a Title Case display name on every job, and these synced callers are the last two jobs in claude-code-plugins without one: - managed-files-guard and its fleet variant: job pr-check-managed-files is named "PR Check Managed Files", which becomes the check context on every target. No ruleset requires that context; the only reader found (claude-code-plugins reconcile.mjs) keys on the workflow path. - lychee-online's claude-code-plugins caller: job check-links is named "Check Links". The test and the docs that stated the context now name it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe
…-adoption # Conflicts: # components/github-actions-conventions/naming-lint.mjs # components/github-actions-conventions/naming-lint.test.mjs
…rule The loader test assumed exemptions[0] waives workflow-name; the workflow-filename exemptions this branch adds now sort first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe
kyle-sexton
marked this pull request as ready for review
November 11, 2026 23:54
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review needs no new review of No security issues found in this pull request. I read the full diff (10 files). It is naming and vocabulary work plus documentation:
Checked and absent from the diff:
The protected-class register was not consulted, because no standing instruction is deleted or softened. critical-findings: 0 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
claude-review reviewed Incremental review of components/github-actions-conventions/README.md (since 953436e). The only change adds a blank line after the "Pending renames" bullet, so the "GitHub's dynamic workflows..." sentence renders as its own paragraph instead of a lazy continuation of the bullet. No rule text changed, so there is nothing to reconcile in other files. No findings. The PR uses |
kyle-sexton
enabled auto-merge (squash)
November 11, 2026 23:56
Without a blank line the dynamic-workflows sentence rendered inside the bullet as a lazy continuation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: melodic-software/claude-code-plugins#15394
Summary
Lets claude-code-plugins run naming-lint enforcing inside its required check (owner decision Q33: every org repository runs the lint). Today it has 20 blocking findings, all file or action-directory names.
Stacked on #983.
Fix
reenter; maintenanceaudit-lane-runs,check-upstream-drift,delete-stale-branches,file-dead-links,file-recurring-issues,monitor-signals,reconcile-lost-runs; post-mergeselect-mutation-range,test-mutation; prrate-merge-risk) and verbsdelete,log,monitor,open,rate,reenter,seal.dependabot-fragments,eval-browser-dispatch,eval-hill-climb-pass,security-outside-actor,pr-feedback-dispatch,post-merge-demotion-alert), tracked in ci: rename six workflows the org naming lint rejects claude-code-plugins#15394. Each gets a repository-scopedworkflow-filenameexemption naming that issue; every other rule still applies to those files.pr-check-managed-filesis namedPR Check Managed Files, now the check context on every target; no ruleset requires it, and the only reader found (claude-code-pluginsreconcile.mjs) keys on the workflow path. lychee-online's claude-code-plugins callercheck-linksis namedCheck Links. Test and docs follow (managed-files-guard.test.sh: 167 pass).expectedNamenow picks aworkflow-nameexemption instead of index 0.Verification
node --test components/github-actions-conventions/naming-lint.test.mjs: 21 pass, 0 fail.origin/mainsnapshot:334 finding(s), 0 blocking(all warnings: job-name, step-name, job-id).Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe