Skip to content

code-review-rules: enroll the six URL-form sync targets in review-instructions #726

Closed

Description

@kyle-sexton

Split out of #669 (item 2: "Canonical-URL pointer unverified").

Problem

Six sync targets have no root REVIEW.md, so their AGENTS.md ## Code Review Rules pointer links the canonical URL https://github.com/melodic-software/standards/blob/main/REVIEW.md. The #656 probe only showed Codex following in-repo links. Nobody has verified that the Codex reviewer fetches the URL form.

The six targets are not enrolled in the review-instructions sync component. That component syncs REVIEW.md and is already managed in ci-workflows, claude-code-account-rotation, claude-code-plugins, dotfiles, github-iac and provisioning. No recorded reason for leaving these six out was found.

Target Visibility
.github public
agent-plugins public
ci-runner public
claude-code-proxy private, presumed URL form (not readable from the cloud session)
codex-plugins public
cursor-plugins public

Plan

  1. standards: add review-instructions to the managed: list of all six targets in distribution/sync-manifest.yml, after repository-text. Extend expected_review_instructions_targets in distribution/sync-manifest.test.sh to the 12-target list. This was verified on a scratch copy: sync-manifest.test.sh passed 336/336, including [196] REVIEW.md reaches every enrolled ... target, and sync-manifest.sh validate exited 0.
  2. Each of the six repos, right after its (automerge-armed) sync PR lands REVIEW.md: switch the AGENTS.md pointer to the managed form.
    -- Org-wide criteria: [`REVIEW.md`](https://github.com/melodic-software/standards/blob/main/REVIEW.md) in `melodic-software/standards`.
    +- Org-wide criteria: [`REVIEW.md`](REVIEW.md), synced from `melodic-software/standards`.
    This was simulated on agent-plugins:
    • with REVIEW.md present and the pointer unchanged, the checker reports MISSING: ... the REVIEW.md pointer must link REVIEW.md (root REVIEW.md present: true)
    • after the pointer edit, it reports OK
  3. standards: update the components/code-review-rules/README.md paragraph on the absent case to say that no audited target uses the URL form. Keep the URL form documented for non-target repositories.

Ordering hazard

Between a repo's sync merge and its pointer PR, the daily maintenance-audit-code-review-rules run is red for that repo. Land each pointer PR right after its sync PR merges.

Constraint

melodic-software/.github cannot be attached to cloud sessions, because repo names starting with . are refused. Its pointer edit needs a local session or a human.

Refs: #669

Activity

  1. kyle-sexton commented on Oct 30, 2026

    @kyle-sexton
    MemberAuthor

    Done. standards#917 enrolled the six URL-form targets in review-instructions and updated the code-review-rules README. Each target's AGENTS.md now points to its local synced REVIEW.md: .github#222, agent-plugins#117, ci-runner#515, claude-code-proxy#368, codex-plugins#159, cursor-plugins#136. claude-code-proxy's root-coverage check also needed REVIEW.md as a documentation root (claude-code-proxy#366).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions