Repository navigation
docs: drop stamps from pointer records (harness-config, harness-memory) - #15464
kyle-sexton wants to merge 5 commits into
Conversation
Under upstream-drift 5.0.0 a pointer record carries no as-of date or recheck trigger; only stored values keep them. This change removes the stamps from pointer records in the harness-config and harness-memory skill bodies, references, context files and README. Stored values (probe results, defaults, version gates, source conflicts, no-docs-page records) keep their stamps. Recorded decisions keep their named trigger and lose only the date. Two prose lines that told authors to stamp every pointer now match the contract. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcupojQwC9uJAfmSt4EHZm
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Chunk 1 of 2 (40 files)Security review (chunk 1 of 2): no security issues foundScope. I read every hunk of all 40 files in What changed. The change matches the PR description, which is batch 2 of the upstream-drift stamp sweep. Nearly every hunk deletes an
Instruction-surface lens. The diff narrows standing skill and reference text, so I checked each removed line against the protected classes in The guardrails next to these records are unchanged, for example:
No command, path, URL or tool input that a session runs or fetches changed. The links point to the same sections as before. Trust controls and manifests. This chunk has no workflow, action, script, hook, settings file, Settled threads. The single settled thread (env-vars "rows carry no section anchors", in Embedded text. The PR context, settled-threads and prior-findings files contain no directive aimed at the review lane. Prior findings. Last round's only entry is a summary comment that reported 0 findings, so nothing is restated. This review was blocking only ( Spend. None. The change does not alter lane runs, models, effort or schedules. critical-findings: 0 Chunk 2 of 2 (3 files)Security review (chunk 2 of 2): no security issues foundScope. I read every hunk of the 3 files in
All three are Markdown skill and reference text. None matches a What changed. Every hunk removes upstream-drift metadata and nothing else: Instruction-surface lens. This diff narrows standing skill text, so I checked each removed line by its consequence. I did not read the protected-class register (
No command, path or URL that a session runs or fetches changed. Every link points to the same section as before. Trust controls and manifests. This chunk has no workflow, action, script, hook, settings file, Settled threads. The one settled thread (the env-vars note "rows carry no section anchors" in Prior findings. The only earlier entry is last round's summary comment, which reported 0 findings, so nothing is restated. This review was blocking only ( Embedded text. The PR context, the settled-threads file and the diff contain no directive aimed at the review lane. Spend. None. This chunk does not change lane runs, models, effort or schedules. critical-findings: 0 |
|
claude-review reviewed Chunk 1 of 2 (40 files)Code review, chunk 1 of 2: PR #15464 at
|
Owner decision D26 narrows "stored value" to a record that holds a number or string copied or measured from upstream. This pass removes the remaining stamps from records that hold only behavior descriptions, "no docs page covers" notes, source conflicts with no value, "last researched" dates, and file-wide trigger blocks. Probe hashes and byte counts, defaults, version gates, model and effort literals, and hardcoded lists keep their stamps. The unhobble eval no longer requires an as-of date and trigger on the enabledPlugins precedence claim. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcupojQwC9uJAfmSt4EHZm
…6.0.0 I30's Detect text described every record as carrying an as-of date and a recheck trigger. Under the contract a pointer record carries no stamp, and only a stored value (a recorded number or string copied or measured from upstream) keeps an as-of date and trigger. I30's finding, a dated stamp with no trigger, is unchanged; only its description of the record changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcupojQwC9uJAfmSt4EHZm
…robe The first-party repro of path-scoped rule deferral records the Claude Code version it was measured on, so under D26 it is a stored value and keeps its date and recheck trigger. Restored in official-guidance.md (date and trigger) and criteria.md (date). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcupojQwC9uJAfmSt4EHZm
No related issue: batch 2 of the Q11 sweep that applies the upstream-drift 5.0.0 rule from #15449 (narrowed by owner decision D26) to existing records; it has no tracking issue.
Summary
Under upstream-drift 5.0.0, a pointer record carries no as-of date or recheck trigger. Owner decision D26 narrows the term "stored value" to a record that holds a number or string copied or measured from upstream. This PR removes the stamps from every other record in
harness-configandharness-memory: skill bodies, references, context files and README prose.Fix
lib/,scripts/fetch-docs.sh), code and test files, and CHANGELOG.harness-memory/skills/audit/context/update.md;audit-prompting-postures/reference/postures.md;audit-permission-state/SKILL.md;unhobble,conflict-criteria,stateless/SKILL.mdandaudit-permission-state.#Nreferences were exempt from check-skill check 29 only because they sat in a stamped block. They are now inowner/repo#Nform:anthropics/claude-code#83766andmelodic-software/claude-code-plugins#12039.harness-config/skills/unhobble/evals/evals.json(expected_output and expectation, about lines 208 and 213), the enabledPlugins precedence claim is still graded on its basis and pointer, but no longer on an as-of date and trigger. That record lost its stamp under D26.Counts (as-of dates / recheck triggers, CHANGELOG and evals excluded)
A consistency re-scan of the full diff looked for removed stamps on records that hold a version, count, byte size, hash, timing or exit code. It found one such record: the 2.1.219 path-scoping probe. Its date and trigger are restored in
harness-memory/skills/audit/reference/official-guidance.md, and its date incriteria.md. The counter does not match the date forms "verified working 2026-07-24" and "(2026-07-24)", so it shows only the restored trigger. The other flagged records cite a model or spec version, or are negative reads with no stored figure.Of the 123 dates that remain, 22 are in shared copies and code comments, which are out of scope. The rest are stored values under D26, or are listed below. The remaining triggers are mostly decision triggers whose date was removed.
Restated behavior to cut
These passages paraphrase an upstream page. Their stamps are removed; the prose stays for a follow-up.
harness-config/skills/audit-instructions/reference/criteria.md:ultracodekeyword;budget_tokenschange restarts the cache;disable-model-invocationhides the description.audit-instructions/reference/conflict-criteria.md:disallowed-toolsremove the tool.${…}resolution, in three places:audit-pass/SKILL.md:461-466,audit/SKILL.md:465andaudit-permission-grants/SKILL.md:196.audit-permission-grants/SKILL.md:214: a checked-in skill can grant itself tool access.audit/reference/audit-checklist.md:skillOverridesscope;fallbackModelcap source;/statusshows the managed source.audit-permission-grants/reference/criteria.md:267-273: parenthesis and trailing-text parsing.audit-permission-state/reference/criteria.md:425-435: the content-scoped ask caveat.audit-pass/reference/finding-identity.md:125-126: SARIF versioned fingerprints.audit-prompting-postures/reference/postures.md:59-63: Fable 5.2 self-review.setup/reference/wsl-profile.md:35-41: deny-rule limits.harness-memory/skills/audit/reference/official-guidance.md:282-291: the compaction table.harness-memory/skills/audit/reference/criteria.md:harness-memory/skills/stateless/context/desktop.md:15-22: the Help Center guided steps.Kept, unsure
audit-instructions/reference/criteria.md:audit-pass/reference/finding-identity.md:46, :61, :179andsuppression.md:86: verbatim spec quotes, kept as copied strings.audit-permission-grants/reference/criteria.md:78: nested-skill discovery paths, read as a hardcoded list.audit/reference/required-permissions.md:286: copied strings beside a comparison with our own standards floor.harness-memory/skills/audit/reference/official-guidance.md:192: issue-state strings.harness-memorycriteria.md:11, which the update action bumps, andconflict-criteria.md:20. These are versions of our own files, not upstream stamps.I30 record description (contract 6.0.0, #15468)
audit-instructions/reference/criteria.mdI30 Detect now says that a pointer record carries no stamp. A stored value, meaning a recorded number or string, carries an as-of date and a recheck trigger. I30's finding, a dated stamp with no trigger, applies to those. Behavior is unchanged:emit-findings.shand the tests do not cite the old wording.Review thread
Verification
check-skill.shon both skills roots: 12 passed, 0 failed. Warnings per skill equal the base.sync-shared-copies.sh --check: all 802 copies match.check-changelog-fragments.sh --check: valid.--offline --include-fragmentson the changed files: 0 errors.instruction-scan.test.sh: 178 of 178 passed.emit-findings.test.shfails 16 of 184 checks, the same 16 as on base369976e7d4b6, and this PR does not change any script.evals.jsonparses. Pre-commit and pre-push hooks passed, includingcheck-affected.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01VcupojQwC9uJAfmSt4EHZm