Repository navigation
chore: sync standards components - #15429
Conversation
|
claude-security-review reviewed Security review: PR #15429 (chore: sync standards components)No security issues found. I read every hunk of the diff. It has 6 files: 4 first paths plus 2 byte-identical copies, as listed in
The PR description is a plain list of the sync's mappings. It contains no text telling the lane to pass the PR, skip a check or drop a finding. critical-findings: 0 |
|
claude-review reviewed CI code review: PR #15429 (chore: sync standards components)Complete review: I read all 6 changed files. Two pairs are byte-identical, so I read the first file of each pair, and the job counts the copies:
Each copy's path is a plugin's changelog fragment or reference file. Neither is a hook, workflow, settings or manifest path, so the content does nothing different at the copied path. No findings. What changed:
Closing issue: none. The PR body says this is a recurring automated sync with no linked issue. Embedded text: the PR body's "Do not hand-edit these managed files downstream" is guidance about how the files are maintained. It asks nothing of this lane. Spend: none of note. The managed-files guard now also runs on pull requests that touch the 7 added paths, a small number of GitHub-hosted runner minutes. |
|
The pr-unblock lane stopped
When a retry on this head can change the outcome, the lane runs one on its own, up to its per-head cap, and edits this comment if it stops again; a run that does not stop clears the status. When no retry can (a review thread the lane does not take or settle, or a failing check after the retries are spent), a person resolves the threads or gets the checks green, then dispatches the workflow below: that run finds the cause gone and clears the status. On a pull request the lanes App opened, the dispatchers start that run once per stop; on any other, a person does. A new commit to the branch starts clean. To run it again on this head now, dispatch the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=15429 -f activity=fix-ci |
#988) No related issue: follow-up to #986 (owner-approved issue-body contract design) ## Summary #986 synced the issue-body contract into two plugin directories of `claude-code-plugins`. Its sync PR, melodic-software/claude-code-plugins#15429, cannot pass: `scripts/check-cross-plugin-source-drift.sh` refuses a file byte-identical across two plugins unless the same change registers it, and a registry entry cannot land first because the check also refuses an entry with fewer than two copies (STALE BASELINE). A sync PR cannot carry that registration. ## Fix - `sync-manifest.yml`: `issue-body-contract-bugs` and `issue-body-contract-work-items` become one component, `issue-body-contract-plugins`, delivering `contract.json` to `docs/contracts/issue-body/contract.json` in `claude-code-plugins`. That repository's `sync-shared-copies.sh` fans the canonical into each plugin's `reference/`, registered in the same change, as it already does for `docs/contracts/standards/README.md`. - The hosted managed-files guard lists the new destination instead of the two plugin paths. - The component README names the new path. ## Verification - `bash distribution/sync-manifest.sh validate`: valid, 52 components, 15 targets. - `components/managed-files-guard/managed-files-guard.test.sh`: passes. - In a `claude-code-plugins` checkout, a registry entry for `reference/issue-body-contract.json` without the copies fails `check-cross-plugin-source-drift.sh --check` with STALE BASELINE (exit 1), which rules out registering first. ## Related - #986 - melodic-software/claude-code-plugins#15429 (the sync PR this push refreshes) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
80d79d1 to
9d8cbb1
Compare
Summary
Automated exact-file synchronization from
melodic-software/standards@1af4bb247c890ec874d0c5986eb7c280441b4502(requested refmain).No linked issue — recurring automated distribution, not tied to a tracked change.
Fix
Managed component mappings applied to
melodic-software/claude-code-plugins:.github/actionlint.yaml→.github/actionlint.yaml(mode100644)components/dependabot-policy/policy.json→.github/standards/dependabot-policy/policy.json(mode100644).editorconfig-checker.json→.editorconfig-checker.json(mode100644)components/engineering-standards/standards-index.md→docs/standards/README.md(mode100644)standards/engineering/bulk-mutation.md→docs/standards/bulk-mutation.md(mode100644)standards/engineering/concise-prose.md→docs/standards/concise-prose.md(mode100644)standards/engineering/design-for-change.md→docs/standards/design-for-change.md(mode100644)standards/engineering/deterministic-work-execution.md→docs/standards/deterministic-work-execution.md(mode100644)standards/engineering/documentation-and-citations.md→docs/standards/documentation-and-citations.md(mode100644)standards/engineering/reference-dont-duplicate.md→docs/standards/reference-dont-duplicate.md(mode100644)standards/engineering/simpler-code.md→docs/standards/simpler-code.md(mode100644)standards/engineering/source-authority-tiers.md→docs/standards/source-authority-tiers.md(mode100644)standards/process/issue-tracker.md→docs/standards/issue-tracker.md(mode100644)components/github-actions-conventions/vocabulary.json→.github/standards/github-actions-conventions/vocabulary.json(mode100644)components/github-actions-conventions/vocabulary.schema.json→.github/standards/github-actions-conventions/vocabulary.schema.json(mode100644).gitleaks.toml→.gitleaks.toml(mode100644)components/issue-body-contract/contract.json→docs/contracts/issue-body/contract.json(mode100644)lychee.toml→lychee.toml(mode100644)components/lychee-online/targets/claude-code-plugins.yml→.github/workflows/maintenance-check-links-online-claude-code-plugins.yml(mode100644)components/managed-files-guard/managed-files-guard.yml→.github/workflows/pr-check-managed-files-hosted.yml(mode100644).markdownlint-cli2.jsonc→.markdownlint-cli2.jsonc(mode100644).node-version→.node-version(mode100644)components/path-detection/machine-path-patterns.sh→plugins/guardrails/lib/path-detection/machine-path-patterns.sh(mode100644).claude/rules/pr-body-contract.md→.claude/rules/pr-body-contract.md(mode100644)components/pyright/pyrightconfig.json→.github/standards/pyright/pyrightconfig.json(mode100644).editorconfig→.editorconfig(mode100644).gitattributes→.gitattributes(mode100644)REVIEW.md→REVIEW.md(mode100644)components/runner-policy/package-lock.json→.github/standards/runner-policy/package-lock.json(mode100644)components/runner-policy/package.json→.github/standards/runner-policy/package.json(mode100644)components/runner-policy/policy.json→.github/standards/runner-policy/policy.json(mode100644)components/runner-policy/policy.schema.json→.github/standards/runner-policy/policy.schema.json(mode100644)components/runner-policy/repository-policy.schema.json→.github/standards/runner-policy/repository-policy.schema.json(mode100644)components/runner-policy/runner-policy.mjs→.github/standards/runner-policy/runner-policy.mjs(mode100755).shellcheckrc→.shellcheckrc(mode100644)components/trusted-actors/trusted-actors.json→.github/standards/trusted-actors/trusted-actors.json(mode100644)components/trusted-actors/trusted-actors.schema.json→.github/standards/trusted-actors/trusted-actors.schema.json(mode100644)_typos.toml→_typos.toml(mode100644).github/zizmor.yml→.github/zizmor.yml(mode100644)Verification
Review and merge this PR normally. Do not hand-edit these managed files downstream; change their standards source instead.
Related
melodic-software/standards@1af4bb247c890ec874d0c5986eb7c280441b4502— source commit this sync distributes.