code-tidying: run upkeep as a daily batch of at most 3 PRs #12475

Activity

1. kyle-sexton

   added

   priority: medium

   work-class: scoped

   status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.A maintainer confirmed the item is real and in scope; ready to be worked.

   on Nov 2, 2026
2. kyle-sexton

   added a parent issue on Nov 2, 2026

   • code-tidying: remove-comments and upkeep cadence #7585
3. github-actions commented on Nov 2, 2026

   

   github-actionsBot

   on Nov 2, 2026 – with GitHub Actions

   Last edited by melodic-automation-lanes

   Contributor

   More actions

   Proposed work class: work-class: scoped
   Basis: automated intake triage; the lanes App applied this class.

   Size: Medium
   Complexity: Medium
   Uncertainty: Known
   Flags: none
   Blocked by: none

   I understood this as slice 2 of 2 of #7585. Code-tidying upkeep detection would run per merge. Upkeep PRs would open as a daily batch, with churn-triggered area sweeps and a weekly backstop. At most 3 upkeep PRs would be open at once. The cadence, backstop and cap would be settings read from the convention home (#7571). The outcome, done-when items and decisions are exact, so I have no open questions. I found no duplicate. The nearest open issue is the sibling slice 1 (the remove-comments rename), which this issue lists as out of scope. #7571 is not in the open issues list, so I treated it as not blocking.

   _{Automated triage, applied by the lanes App.}
4. github-actions

   added the

   Feature

   issue type on Nov 2, 2026
5. melodic-automation-lanes

   added

   status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.

   on Nov 2, 2026
6. melodic-automation-lanes

   set

   Work status

   to

   ready

   on Nov 2, 2026
7. melodic-automation-lanes

   added

   admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.Admitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.

   on Nov 2, 2026
8. melodic-automation-lanes

   changed

   Work status

   to

   deferred

   on Nov 2, 2026
9. melodic-automation-lanes

   added

   agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.Fully specified and briefed; eligible for autonomous pickup from the frontier.

   and removed

   admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.Admitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.

   status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.A maintainer confirmed the item is real and in scope; ready to be worked.

   on Nov 2, 2026
10. melodic-automation-lanes

    changed

    Work status

    to

    agent-ready

    on Nov 2, 2026
11. github-actions commented on Nov 2, 2026

    

    github-actionsBot

    on Nov 2, 2026 – with GitHub Actions

    Last edited by github-actions

    Contributor

    More actions

    No description provided.
12. 1 remaining item

    Load more
13. melodic-automation-lanes

    added

    host-runNeeds an unattended run on a host; the host runner takes it, not a person or the issue lane.Needs an unattended run on a host; the host runner takes it, not a person or the issue lane.

    and removed

    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.Fully specified and briefed; eligible for autonomous pickup from the frontier.

    on Nov 2, 2026
14. melodic-automation-lanes commented on Nov 2, 2026

    

    melodic-automation-lanesBot

    on Nov 2, 2026

    Contributor

    More actions

    The work-resolve-issue lane stopped on this issue (patch-protected-path): the change needs a path the issue lane may not push, which a maintainer session builds by hand.
    It added host-run and removed agent-ready: an agent run on a host builds it, and it waits on no decision from a person.

    In the run's words:

    The run stopped early (patch-protected-path): its change needs a path the issue lane may not push, which a person changes instead. In the run's words: patch-protected-path: .github/workflows/** (a new workflow, such as .github/workflows/maintenance-code-tidying-upkeep.yml, with a push-to-main trigger for per-merge detection and daily and weekly schedule triggers). The issue's done-when needs upkeep detection to run on each merge, upkeep PRs to open as a daily batch and a weekly backstop to run. This repository runs scheduled and per-merge automation only as .github/workflows/maintenance-*.yml workflows, and code-tidying has no such lane yet. A new lane would probably also need an entry in /.github/actions/resolve-config/lane-grants.json, which is protected as well.

    What the run says it did not do:

    • All four done-when items (per-merge detection with a daily batch, churn sweeps with a weekly backstop, the 3-PR cap, and the settings in the convention home). Each needs a new workflow under the protected .github/workflows/** path.
    • Repository checks (check-changelog-fragments, check-changed-skills, check-affected) were not run, because the working tree is unchanged.

    Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/41513850288

    To hand it back to the lane, remove host-run and add agent-ready again.
15. kyle-sexton

    self-assigned this

    on Nov 3, 2026
16. kyle-sexton commented on Nov 3, 2026

    

    kyle-sexton

    on Nov 3, 2026

    MemberAuthor

    More actions

    No description provided.
17. kyle-sexton

    added 2 commits that reference this issue on Nov 3, 2026

    fix(code-tidying): read the upkeep gate's sweep history to the window…

    ...

    0a703f3

    fix(code-tidying): limit the upkeep backstop to areas with unswept churn

    ...

    794cea0
18. kyle-sexton commented on Nov 3, 2026

    

    kyle-sexton

    on Nov 3, 2026

    MemberAuthor

    More actions

    Decision recorded. Owner, in the lane 2 session, 2026-11-03: "Go with whatever this recommends", with the standing direction attached, answering how the daily upkeep model job gets its token.

    maintenance-code-tidying-upkeep.yml joins the lane token broker's scheduled callers in azure-iac, as upstream-apply-changelog.yml did. Basis: docs/conventions/pr-pipeline/pr-run-activity.md allows schedule from three named workflows only, and the standing direction's section 10 counts holds against our own actors as friction.

    #12614 ships the settings, cap, detection and gate. The model job follows once the broker accepts the caller.
19. kyle-sexton commented on Nov 3, 2026

    

    kyle-sexton

    on Nov 3, 2026

    MemberAuthor

    More actions

    Decision recorded. Owner, in the lane 2 session, 2026-11-03, answering whether the upkeep workflow's scan job may hold SCAN_CARRIER_PRIVATE_KEY, with this as the recommended option: "sure".

    maintenance-code-tidying-upkeep.yml's scan job becomes the third holder under the second holder's limits: main only, contents: read, no id-token, a read-only cache, one open step, no model in that job.
20. kyle-sexton

    added 5 commits that reference this issue on Nov 3, 2026

    fix(code-tidying): keep a sweep's merge out of churn and overdue chur…

    ...

    2190a87

    fix(code-tidying): keep the upkeep gate planning on a full sweep list

    ...

    7a1da0b

    refactor(code-tidying): rename the upkeep lane to maintenance-tidy-co…

    ...

    fb6773e

    feat(github-actions-conventions): reserve the maintenance function co…

    ...

    8214f47

    fix(code-tidying): date a clean sweep by the commit it swept

    ...

    6977e69
21. kyle-sexton

    closed this as completedin #12674on Nov 3, 2026