Switched the hardcoded references from 4 to 8, so that the tool can support up to 8 players.#47
Open
MeltyPlayer wants to merge 1 commit into
Open
Switched the hardcoded references from 4 to 8, so that the tool can support up to 8 players.#47MeltyPlayer wants to merge 1 commit into
MeltyPlayer wants to merge 1 commit into
Conversation
…upport up to 8 players.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the issues that's personally blocking me in my RetroPie setup is not being able to map more than 4 joysticks. I have kind of an odd setup where my joysticks are internally listed as 8 different devices, because my USB encoder buttons are separate from the actual arcade sticks.
I noticed that there's an existing ticket for this exact issue, so I thought I might try tossing my hat into the ring to fix it:
#18
This joystick-selection script is currently hardcoded for 4-player support; I set up a barebones commit that just changes this to 8-player support instead. There are likely at least a couple MAME games that would require more than 4 players (e.g. the X-Men game supports 6 players), so this didn't seem too unreasonable of a change. But please let me know if you have any concerns that I should address.