Fix warnings reported by recent Rust - #45
Merged
Merged
Conversation
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is the result of running
cargo +nightly fix. It fixes inconsistent lifetime elision. Rust warns about it since version 1.89. More details here: rust-lang/rust#138677The second commit fixes numerous warnings about unused functions in the parser module by moving them to an integration test file. It turns out that
src/parser/source.rsonly contained test code. Also, all code insrc/parser/util.rsexceptnumber()was only needed for tests. All that code lives intests/parser.rsnow.