[codex] Anchor prosodic head nod snippets to live pose#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the bundled speaking head nod snippets so each head pitch curve starts from the inherited live pose.
inherit: trueto the first keyframe for AU 54 and AU 53 inheadNodSmall.jsoninherit: trueto the first keyframe for AU 54 and AU 53 inheadNodBig.jsonWhy
Prosodic head nods were starting from neutral keyframes, which can fight live eye/head tracking. The animation runtime already applies inherited first keyframes by offsetting the whole non-eyeHeadTracking curve to the current live value. Because that offset makes the final zero point return to the inherited live value, no last-keyframe marker is needed on this path.
Related to meekmachine/LoomLarge#697. The LoomLarge issue should stay open until the Polyester change is consumed there.
Validation
npm test -- src/animation/__tests__/snippetPreloader.test.tsnpm run typecheck